Update deployment service

- The deployment service was updated to properly handle null and empty values, specifically when the environment variable is set as a value inside the deployment configuration and not through environment variables
oshalygin · Jul 31, 2017 · 1965526 · 1965526
1 parent 6c3eacc
commit 1965526
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG → CHANGELOG.md b/CHANGELOG → CHANGELOG.md
@@ -1,3 +1,7 @@
+## 1.1.0 (July 30, 2017)
+
+- Updated deployment service to now properly handle null and zero values with `omitempty`.
+
 ## 1.0.2 (July 30, 2017)
 
 - Updated deployment test file which includes a strict `value` instead of pulling from configuration

diff --git a/models/deployment.go b/models/deployment.go
@@ -43,7 +43,8 @@ type Container struct {
 	VolumeMounts `yaml:"volumeMounts"`
 	Env          []struct {
 		Name      string
-		ValueFrom `yaml:"valueFrom"`
+		ValueFrom `yaml:"valueFrom,omitempty"`
+		Value     string `yaml:"value,omitempty"`
 	}
 	ImagePullPolicy string `yaml:"imagePullPolicy"`
 	Ports           []struct {