-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump pydid to v 0.4.3 #2737
bump pydid to v 0.4.3 #2737
Conversation
Signed-off-by: pstlouis <[email protected]>
strange, when running the black code formatter locally it detects no changes...I'm using version 23.7.0 |
Signed-off-by: pstlouis <[email protected]>
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
@swcurran I updated to the new black formatter version 24.1 used by the tests, it was released yesterday and seems to behave differently. This 2 line PR turned into a 302 lines PR... |
That's unfortunate -- @PatStLouis no worries on the formatting changes. I think your separation into two different commits is a good compromise. Thanks! It's probably a good idea for us to pin the version of black used in the actions so we can keep it in sync with what we have down in the dev dependencies. But we don't need to worry about that in this PR |
I'll wait for the int tests to run to completion but this looks good to me! |
Test failed but looks like a fluke. Rerunning. |
the error seems to have to do with the anoncreds revocation registry not being available The linting did change the indy/web/legacy registries files however I never heard of code linting breaking code. This would be wild. |
I think this is related to the last anoncreds-rs update, we can check again when we get the anoncreds-rs |
Merging this as is then; thanks @ianco and @jamshale! And thanks for your patience @PatStLouis! |
Addresses #2677
@dbluhm I ran a
poetry update pydid
after changing the version in thepyproject.toml
file. Seems like it did the trick.