Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump pydid to v 0.4.3 #2737

Merged

Conversation

PatStLouis
Copy link
Contributor

Addresses #2677

@dbluhm I ran a poetry update pydid after changing the version in the pyproject.toml file. Seems like it did the trick.

@PatStLouis
Copy link
Contributor Author

strange, when running the black code formatter locally it detects no changes...I'm using version 23.7.0

Copy link

sonarcloud bot commented Jan 26, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@PatStLouis
Copy link
Contributor Author

PatStLouis commented Jan 26, 2024

@swcurran I updated to the new black formatter version 24.1 used by the tests, it was released yesterday and seems to behave differently. This 2 line PR turned into a 302 lines PR...

@dbluhm
Copy link
Contributor

dbluhm commented Jan 26, 2024

That's unfortunate -- @PatStLouis no worries on the formatting changes. I think your separation into two different commits is a good compromise. Thanks!

It's probably a good idea for us to pin the version of black used in the actions so we can keep it in sync with what we have down in the dev dependencies. But we don't need to worry about that in this PR

@dbluhm
Copy link
Contributor

dbluhm commented Jan 26, 2024

I'll wait for the int tests to run to completion but this looks good to me!

@dbluhm
Copy link
Contributor

dbluhm commented Jan 26, 2024

Test failed but looks like a fluke. Rerunning.

@PatStLouis
Copy link
Contributor Author

the error seems to have to do with the anoncreds revocation registry not being available
aries_cloudagent.anoncreds.revocation.AnonCredsRevocationError: No active registry

The linting did change the indy/web/legacy registries files however I never heard of code linting breaking code. This would be wild.

@dbluhm
Copy link
Contributor

dbluhm commented Jan 29, 2024

@ianco or @jamshale any hints what might be going wrong? I agree with Patrick that it seems unlikely that these changes would impact the anoncreds tests.

@jamshale
Copy link
Contributor

@ianco or @jamshale any hints what might be going wrong? I agree with Patrick that it seems unlikely that these changes would impact the anoncreds tests.

The anoncreds integration tests are broken for anoncreds-dev8. They should get fixed with dev9.

I don't think we need to block this for them.

@ianco
Copy link
Contributor

ianco commented Jan 29, 2024

I think this is related to the last anoncreds-rs update, we can check again when we get the anoncreds-rs dev9 release

@dbluhm
Copy link
Contributor

dbluhm commented Jan 29, 2024

Merging this as is then; thanks @ianco and @jamshale! And thanks for your patience @PatStLouis!

@dbluhm dbluhm merged commit b8fbb81 into openwallet-foundation:main Jan 29, 2024
7 of 8 checks passed
@PatStLouis PatStLouis deleted the pstlouis/bump-pydid-version branch January 29, 2024 22:21
@dbluhm dbluhm mentioned this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants