chore: pin black version #2747
Merged
chore: pin black version #2747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbluhm
force-pushed
the
chore/pin-black-version
branch
from
10a849c to
d7b69c3
Compare
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
dbluhm
force-pushed
the
chore/pin-black-version
branch
from
75625c3 to
1b92a0b
Compare
|
ianco
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though relatively infrequent, the result of formatting with black can change from version to version. This PR pins the version of black used in the github action to a specific version. This version should be kept in sync with the version selected in the pyproject.toml to avoid situations where new versions of black cause PR checks to fail because formatting changed between versions.
This PR also bumps the currently selected version of black to 24.1.1, which is the most recent black version that was run in recent PRs. This should provide the best continuity until the next time we choose to update black.
Should correct the issues seen in #2737 and #2746 (black was passing locally).