Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting to the CI pipelines #271

Merged
merged 27 commits into from
Jan 3, 2025
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
eb009ab
feat: adding frontend linting
diofeher Dec 31, 2024
0373d28
feat: uses -> run
diofeher Dec 31, 2024
f714de7
feat: workflow_dispatch
diofeher Dec 31, 2024
ec775a6
feat: remove workflow_dispatch
diofeher Dec 31, 2024
c769648
feat: testing with tsx
diofeher Dec 31, 2024
4f9c568
feat: on pull request
diofeher Dec 31, 2024
542d7ed
feat: npm
diofeher Dec 31, 2024
2c19dea
feat: uses -> run
diofeher Dec 31, 2024
f925183
feat: trigger
diofeher Dec 31, 2024
3fd5643
feat: add working-directory
diofeher Dec 31, 2024
55609fe
feat: right syntax
diofeher Dec 31, 2024
b241b6d
feat: use prettier check
diofeher Dec 31, 2024
6cd046c
feat: revert
diofeher Dec 31, 2024
5e99885
feat: revert2
diofeher Dec 31, 2024
c466763
refactor: better naming and local command
diofeher Jan 2, 2025
b0a39e1
lint: change files breaking prettier
diofeher Jan 2, 2025
bd5bcc1
lint: trigger if any frontend files are changed and metadata
diofeher Jan 2, 2025
d1ac179
prettier ignore
diofeher Jan 2, 2025
de5412b
push to backend/search to trigger backend ci
diofeher Jan 2, 2025
c63084a
index.css lint
diofeher Jan 2, 2025
977c21c
remove debug step
diofeher Jan 2, 2025
e539796
remove frontend.yml and move the code to verify.yml
diofeher Jan 2, 2025
5cc19cb
remove frontend.yml and move the code to verify.yml
diofeher Jan 2, 2025
cdca281
remove frontend.yml and move the code to verify.yml
diofeher Jan 2, 2025
db98571
rename job
diofeher Jan 2, 2025
b6b48ea
remove paths
diofeher Jan 2, 2025
d7e36c6
revert pnpm
diofeher Jan 2, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .github/workflows/frontend-linting.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
on:
diofeher marked this conversation as resolved.
Show resolved Hide resolved
pull_request:
push:
paths:
- '*.tsx?'

jobs:
frontend:
name: Linting
runs-on: ubuntu-latest
defaults:
run:
working-directory: frontend
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Setup Node
uses: actions/setup-node@v4
- name: Install dependencies
run:
npm ci
- name: Run linting
run:
npm run lint
- name: Run Prettier Check
run:
npm run prettier:check:ci
1 change: 1 addition & 0 deletions frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"test": "vitest",
"preview": "vite preview",
"prettier": "prettier --write .",
"prettier:check:ci": "prettier --check .",
diofeher marked this conversation as resolved.
Show resolved Hide resolved
"generate-api-types": "openapi-typescript ../backend/internal/server/openapi.yml -o ./src/api.d.ts",
"generate-assets": "pwa-assets-generator"
},
Expand Down
1 change: 1 addition & 0 deletions frontend/src/remove-me.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
console.log("remove-me.ts");