-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linting to the CI pipelines #271
Add linting to the CI pipelines #271
Conversation
Signed-off-by: Diogenes Fernandes <[email protected]>
f25c525
to
eb009ab
Compare
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @diofeher added a few comments.
Signed-off-by: Diogenes Fernandes <[email protected]>
3e989fb
to
c466763
Compare
@abstractionfactory Do you prefer to have the fixes together with the linting on this PR or in a separate PR? I'm planning to open another PR after this one with the fixes, but asking first before doing any work. |
@diofeher whichever is easier for you :) |
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
91d54b7
to
bd5bcc1
Compare
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
@abstractionfactory thanks again for the support and comments! I just cleaned up the PR, should be good to go |
@diofeher thank you for your work. One question: did you verify that the changed markdown files render correctly? |
@abstractionfactory Yep, I didn't know _ and * were the same on markdown, so I went to check if the generated pdf was the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @diofeher !
There are multiple steps to this PR:
1 - Adding ESLint and Prettier checks to the frontend pipeline
2 - Trigger verify.yml only if backend files are changed.
3 - Trigger frontend.yml only if frontend files are changed.
4 - Add linted files on the frontend (changed with prettier --write)
For linting frontend locally, use
npm run lint
.This PR is meant to close #93 .
Checklist