Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-5.8] LOG-4969: Backport PRs grafana/loki#11624 and grafana/loki#11592 #247

Merged
merged 2 commits into from
Jan 18, 2024
Merged

[release-5.8] LOG-4969: Backport PRs grafana/loki#11624 and grafana/loki#11592 #247

merged 2 commits into from
Jan 18, 2024

Conversation

periklis
Copy link

@periklis periklis requested a review from xperimental January 18, 2024 07:35
@periklis periklis self-assigned this Jan 18, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 18, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 18, 2024 •
edited by openshift-ci bot
Loading

@periklis: This pull request references LOG-4969 which is a valid jira issue.

In response to this:

Backport the following PRs into release-5.8

Replaces:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 18, 2024

@periklis: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xperimental
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: periklis, xperimental

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [periklis,xperimental]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 586aa88 into openshift:release-5.8 Jan 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xperimental xperimental Awaiting requested review from xperimental xperimental is a code owner

@alanconway alanconway Awaiting requested review from alanconway

@JoaoBraveCoding JoaoBraveCoding Awaiting requested review from JoaoBraveCoding

Assignees

@xperimental xperimental

@periklis periklis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@periklis @openshift-ci-robot @xperimental