-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update spotless to meet JDK-21 baseline #533
Conversation
@ansjcy purely formatting updates (spotless update is needed to work with JDK-21) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@@ -34,6 +35,7 @@ | |||
@PowerMockIgnore({"org.apache.logging.log4j.*", "com.sun.org.apache.xerces.*"}) | |||
@RunWith(PowerMockRunner.class) | |||
@PrepareForTest({NetClient.class, InterNodeRpcServiceGrpc.InterNodeRpcServiceStub.class}) | |||
@Ignore("See please https://github.com/opensearch-project/performance-analyzer-rca/issues/529") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #533 +/- ##
=========================================
Coverage 74.41% 74.42%
Complexity 2666 2666
=========================================
Files 317 317
Lines 16377 16377
Branches 1282 1282
=========================================
+ Hits 12187 12188 +1
+ Misses 3675 3674 -1
Partials 515 515 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andriy Redko <[email protected]>
Looks like this is the change required for 2.12 builds to pass, opensearch-project/performance-analyzer#611, can we please get this in soon and backport to 2.x? |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-533-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3c92f12e3ef0789bc7c7bda2a28b85a350008e80
# Push it to GitHub
git push --set-upstream origin backport/backport-533-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Add JDK-21 to Github actions
Describe the solution you are proposing
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.