Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [2.x] Update spotless to meet JDK-21 baseline (#618) #627

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

reta
Copy link
Contributor

@reta reta commented Feb 9, 2024

Backport of #618 to 2.x

@reta reta force-pushed the backport/backport-618-to-2.x branch from 200ec33 to a9ff1c4 Compare February 9, 2024 21:35
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f8666da) 68.70% compared to head (f021c13) 68.54%.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #627      +/-   ##
============================================
- Coverage     68.70%   68.54%   -0.17%     
+ Complexity      365      364       -1     
============================================
  Files            43       43              
  Lines          2473     2473              
  Branches        172      172              
============================================
- Hits           1699     1695       -4     
- Misses          671      674       +3     
- Partials        103      104       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

(cherry picked from commit 6c4400d)
Signed-off-by: Andriy Redko <[email protected]>
@reta reta force-pushed the backport/backport-618-to-2.x branch from a9ff1c4 to f021c13 Compare February 9, 2024 21:41
@ansjcy
Copy link
Member

ansjcy commented Feb 9, 2024

Thank you @reta for updating this.

@prudhvigodithi
Copy link
Member

Along with this need this PR to get in as well opensearch-project/performance-analyzer-rca#533. PA clones PA-RCA during build. With all these PR’s I have tested on my local and ./gradlew clean build PA looks green, can we please get these PR’s soon?

@ansjcy ansjcy merged commit f3acfe4 into opensearch-project:2.x Feb 9, 2024
6 of 7 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 9, 2024
(cherry picked from commit 6c4400d)
Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit f3acfe4)
ansjcy pushed a commit that referenced this pull request Feb 9, 2024
(cherry picked from commit 6c4400d)
Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit f3acfe4)

Co-authored-by: Andriy Redko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants