81 supplier plugin health and store usage #84
Conversation
Signed-off-by: Johannes Peter <[email protected]>
…trQueryParserPlugin Signed-off-by: Johannes Peter <[email protected]>
…ecated Signed-off-by: Johannes Peter <[email protected]>
JohannesDaniel
requested review from
gsingers,
macohen and
sstults
as code owners
|
Can you fix the failed CI ? |
|
Neither @JohannesDaniel nor I could reproduce the failure of JDK17. I reran the CI tests 10 times and still could not get a failure. Given that JDK17 is being phased out of main I'm going to merge this PR. |
|
@ylwu-amzn @sstults I think this is simply a test that fails from time to time |
|
|
||
|
|
||
|
|
||
| // private |
| @@ -0,0 +1,61 @@ | |||
| package org.opensearch.ltr.stats.suppliers; | |||
| .reduce(STATUS_GREEN, this::combineStatuses); | ||
| } | ||
|
|
||
| private String combineStatuses(String s1, String s2) { |
There was a problem hiding this comment.
Make the variable name more readable: s1, s2
|
Why this PR merged without approval? |
@ylwu-amzn that's me probably misunderstanding policy. My assumption was that by merging I'm implicitly approving. That was exacerbated by my other mistake of assuming that passing CI tests was your only comment on this PR. @JohannesDaniel I'm going to revert so that the above issues can be resolved. |
|
@sstults no worry, I added more comments later. Thanks for the reverting |
Signed-off-by: Johannes Peter <[email protected]> (cherry picked from commit e58e20d)
Description
The feature is expected to
Issues Resolved
#81
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.