81 supplier plugin health and store usage after revert #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Peter <[email protected]>
…trQueryParserPlugin Signed-off-by: Johannes Peter <[email protected]>
…ecated Signed-off-by: Johannes Peter <[email protected]>
Signed-off-by: Johannes Peter <[email protected]>
JohannesDaniel
requested review from
gsingers,
macohen and
sstults
as code owners
|
@ylwu-amzn new PR after revert. Fixed
|
|
I added some comments to the old PR, can you help address those comments first ? #84 |
JohannesDaniel
commented
Dec 13, 2024
JohannesDaniel
commented
Dec 13, 2024
src/main/java/org/opensearch/ltr/stats/suppliers/PluginHealthStatusSupplier.java
Show resolved
Hide resolved
JohannesDaniel
commented
Dec 13, 2024
src/main/java/org/opensearch/ltr/stats/suppliers/PluginHealthStatusSupplier.java
Outdated
Show resolved
Hide resolved
rithin-pullela-aws
approved these changes
Dec 13, 2024
ylwu-amzn
reviewed
Dec 13, 2024
src/main/java/org/opensearch/ltr/stats/suppliers/StoreStatsSupplier.java
Show resolved
Hide resolved
ylwu-amzn
reviewed
Dec 13, 2024
src/test/java/org/opensearch/ltr/stats/suppliers/PluginHealthStatusSupplierTests.java
Show resolved
Hide resolved
Signed-off-by: Johannes Peter <[email protected]>
Signed-off-by: Johannes Peter <[email protected]>
sstults
pushed a commit
to sstults/opensearch-learning-to-rank-base
that referenced
this pull request
Dec 19, 2024
…oject#89) Signed-off-by: Johannes Peter <[email protected]> (cherry picked from commit aced4bd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes some refactorings for comments in #84