Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for multiple test verbs. #724

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Dec 10, 2024

Description

Alternative to #723.

You can now do this:

- synopsis: Use POST and PUT interchangeably.
  path: /{index}
  method:
    - POST
    - PUT

Avoids duplicating the test.

Added tests and fixed /_render/template.

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Changes Analysis

Commit SHA: 41446b8
Comparing To SHA: 6341e87

API Changes

Summary

└─┬Paths
  ├─┬/_render/template/{id}
  │ ├─┬GET
  │ │ └─┬Requestbody
  │ │   └─┬application/json
  │ │     └─┬Schema
  │ │       ├──[➕] properties (27315:15)
  │ │       ├──[➖] properties (27315:15)❌ 
  │ │       └─┬params
  │ │         └──[🔀] additionalProperties (27323:39)❌ 
  │ └─┬POST
  │   └─┬Requestbody
  │     └─┬application/json
  │       └─┬Schema
  │         ├──[➕] properties (27315:15)
  │         ├──[➖] properties (27315:15)❌ 
  │         └─┬params
  │           └──[🔀] additionalProperties (27323:39)❌ 
  └─┬/_render/template
    ├─┬GET
    │ └─┬Requestbody
    │   └─┬application/json
    │     └─┬Schema
    │       ├──[➕] properties (27315:15)
    │       ├──[➖] properties (27315:15)❌ 
    │       └─┬params
    │         └──[🔀] additionalProperties (27323:39)❌ 
    └─┬POST
      └─┬Requestbody
        └─┬application/json
          └─┬Schema
            ├──[➕] properties (27315:15)
            ├──[➖] properties (27315:15)❌ 
            └─┬params
              └──[🔀] additionalProperties (27323:39)❌ 

Document Element Total Changes Breaking Changes
paths 12 8
  • BREAKING Changes: 8 out of 12
  • Modifications: 4
  • Removals: 4
  • Additions: 4
  • Breaking Removals: 4
  • Breaking Modifications: 4

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12280552975/artifacts/2306872997

API Coverage

Before After Δ
Covered (%) 606 (59.35 %) 606 (59.35 %) 0 (0 %)
Uncovered (%) 415 (40.65 %) 415 (40.65 %) 0 (0 %)
Unknown 43 43 0

Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
536 475 (88.62 %)

@dblock dblock force-pushed the multiple-verb-chapters branch 2 times, most recently from 22d446d to 6327d3d Compare December 11, 2024 13:31
nhtruong
nhtruong previously approved these changes Dec 11, 2024
tools/src/tester/StoryParser.ts Outdated Show resolved Hide resolved
tools/src/tester/StoryParser.ts Outdated Show resolved Hide resolved
@nhtruong nhtruong merged commit 01f222e into opensearch-project:main Dec 11, 2024
30 checks passed
@dblock dblock deleted the multiple-verb-chapters branch December 11, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants