Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Msearch template API tests #735

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Conversation

Tokesh
Copy link
Collaborator

@Tokesh Tokesh commented Dec 15, 2024

Description

GET /{index}/_msearch
GET /{index}/_msearch/template
POST /{index}/_msearch/template
GET /_msearch/template
POST /_msearch/template

Issues Resolved

[#663 ]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Tokesh and others added 3 commits December 15, 2024 23:10
Copy link
Contributor

github-actions bot commented Dec 15, 2024

Changes Analysis

Commit SHA: 5666d68
Comparing To SHA: 150159b

API Changes

Summary

└─┬Components
  └─┬_core.msearch_template___TemplateConfig
    └─┬params
      └─┬Schema
        ├──[➖] type (43627:19)❌ 
        ├──[➕] oneOf (43629:17)
        └──[➕] oneOf (43628:17)

Document Element Total Changes Breaking Changes
components 3 1
  • BREAKING Changes: 1 out of 3
  • Removals: 1
  • Additions: 2
  • Breaking Removals: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12374788485/artifacts/2332228089

API Coverage

Before After Δ
Covered (%) 606 (59.35 %) 606 (59.35 %) 0 (0 %)
Uncovered (%) 415 (40.65 %) 415 (40.65 %) 0 (0 %)
Unknown 43 43 0

Copy link
Contributor

github-actions bot commented Dec 15, 2024

Spec Test Coverage Analysis

Total Tested
536 517 (96.46 %)

@Tokesh Tokesh marked this pull request as ready for review December 15, 2024 18:16
@Tokesh Tokesh changed the title added msearch template tests Msearch template API tests Dec 16, 2024
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, some small asks.

CHANGELOG.md Outdated Show resolved Hide resolved
tests/default/_core/msearch_template.yaml Outdated Show resolved Hide resolved
tests/default/_core/msearch_template.yaml Outdated Show resolved Hide resolved
tests/default/indices/msearch.yaml Show resolved Hide resolved
tests/default/indices/msearch_template.yaml Outdated Show resolved Hide resolved
tests/default/indices/msearch_template.yaml Outdated Show resolved Hide resolved
@dblock
Copy link
Member

dblock commented Dec 17, 2024

The failed test is #738. Seems to happen often, I'll add a retry into it.

type: object
oneOf:
- type: string
- type: object
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's an example where this is a string? The description says these are key/value pairs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's a key-value pair. Here’s one example: link.

Initially, it seems there was an expectation that the value would be in the form of an object, but I demonstrated with an example that it can also be a string.

@Tokesh Tokesh requested a review from dblock December 17, 2024 14:34
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question here.

@Tokesh Tokesh requested a review from dblock December 17, 2024 17:06
@dblock dblock merged commit 4226d83 into opensearch-project:main Dec 17, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants