-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Msearch template API tests #735
Conversation
Signed-off-by: Tokesh <[email protected]>
Signed-off-by: Niyazbek Torekeldi <[email protected]>
Signed-off-by: Tokesh <[email protected]>
Changes AnalysisCommit SHA: 5666d68 API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12374788485/artifacts/2332228089 API Coverage
|
Spec Test Coverage Analysis
|
Signed-off-by: Tokesh <[email protected]>
Signed-off-by: Tokesh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, some small asks.
Signed-off-by: Tokesh <[email protected]>
Signed-off-by: Niyazbek Torekeldi <[email protected]>
The failed test is #738. Seems to happen often, I'll add a retry into it. |
type: object | ||
oneOf: | ||
- type: string | ||
- type: object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's an example where this is a string? The description says these are key/value pairs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's a key-value pair. Here’s one example: link.
Initially, it seems there was an expectation that the value would be in the form of an object, but I demonstrated with an example that it can also be a string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question here.
Description
GET /{index}/_msearch
GET /{index}/_msearch/template
POST /{index}/_msearch/template
GET /_msearch/template
POST /_msearch/template
Issues Resolved
[#663 ]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.