Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail CI with unused test files. #705

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Dec 2, 2024

Description

Failed run with an extra test file: https://github.com/dblock/opensearch-api-specification/actions/runs/12128482379

Include the list of files in the coverage report, then compare it to the actual list of files.

Screenshot 2024-12-02 at 4 45 11 PM

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock added the skip-changelog No need to update CHANGELOG. label Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Changes Analysis

Commit SHA: e32041b
Comparing To SHA: d3c8d65

API Changes

Summary

NO CHANGES

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12128604961/artifacts/2264130647

API Coverage

Before After Δ
Covered (%) 599 (58.67 %) 599 (58.67 %) 0 (0 %)
Uncovered (%) 422 (41.33 %) 422 (41.33 %) 0 (0 %)
Unknown 42 42 0

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Spec Test Coverage Analysis

Total Tested
528 419 (79.36 %)

@nhtruong nhtruong merged commit 3981d33 into opensearch-project:main Dec 3, 2024
28 of 37 checks passed
@dblock dblock deleted the unused-test-files branch December 3, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No need to update CHANGELOG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants