SnapshotManagement namespace api #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alen_abeshov <[email protected]>
Signed-off-by: alen_abeshov <[email protected]>
aabeshov
requested review from
dblock,
harshavamsi,
sachetalva,
nhtruong,
Xtansia,
VachaShah and
Tokesh
as code owners
Changes AnalysisCommit SHA: d265d8d API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12235494772/artifacts/2293472076 API Coverage
|
Spec Test Coverage Analysis
|
Signed-off-by: alen_abeshov <[email protected]>
|
Not ready yet |
Signed-off-by: alen_abeshov <[email protected]>
Signed-off-by: alen_abeshov <[email protected]>
|
Now, it is ready for review! |
dblock
requested changes
Nov 30, 2024
There was a problem hiding this comment.
Thanks.
- Tests aren't running, the
pluginsdirectory is misleading and is there for custom docker setups and is explicitly added to CI with different configuration. We already have https://github.com/opensearch-project/opensearch-api-specification/tree/main/tests/snapshot, so move the tests in there if there needs to be special setup, otherwise put them indefault/sm. - Keep naming to the route naming, just like we don't name "ml" as "machine_learning", keep "sm" as is, so "sm._common.yaml", etc.
- Rename the test files to match the routes, so
_sm/policiesbecomestests/snapshot/sm/policies.yaml. - Split tests and group by API not by theme. So
explaintests should go into their own file with a prologue that creates a policy, then the chapter only calls explain. The file would besm/policies/explain.yaml,start.yaml, etc.
…le.Renamed snapshot managment to 'sm' Signed-off-by: alen_abeshov <[email protected]>
|
@dblock I am not sure what's wrong |
Signed-off-by: alen_abeshov <[email protected]>
dblock
requested changes
Dec 8, 2024
There was a problem hiding this comment.
Looking good!
What's the failure in 2.0? I see some x-version-added: 2.1 so this means the feature was added in 2.1? Change all tests to do >= 2.1, but do dig through the history/code to verify which version the feature was added in.
Iterate to green. Spec validation needs to pass, there are a bunch of language things like quoting variables that do matter since we're using these in the docs.
Signed-off-by: alen_abeshov <[email protected]>
Signed-off-by: alen_abeshov <[email protected]>
Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>
dblock
approved these changes
Dec 9, 2024
spec/namespaces/sm.yaml
Outdated
| operationId: sm.update_policy.0 | ||
| x-operation-group: sm.update_policy | ||
| x-version-added: '2.1' | ||
| description: Updates an existing snapshot management policy. Requires 'if_seq_no' and 'if_primary_term'. |
There was a problem hiding this comment.
Suggested change
| description: Updates an existing snapshot management policy. Requires 'if_seq_no' and 'if_primary_term'. | |
| description: Updates an existing snapshot management policy. Requires `if_seq_no` and `if_primary_term`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding snapshot management(sm) namespace specs.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [#234 ].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.