Changed feature flag name for hybrid search #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
added
skip-changelog
backport 2.x
martin-gaievski
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
sean-zheng-amazon,
model-collapse,
wujunshen,
zane-neo,
ylwu-amzn and
jngz-es
as code owners
Codecov Report
@@ Coverage Diff @@
## main #247 +/- ##
=========================================
Coverage 86.29% 86.29%
Complexity 340 340
=========================================
Files 29 29
Lines 992 992
Branches 153 153
=========================================
Hits 856 856
Misses 70 70
Partials 66 66
|
navneet1v
approved these changes
Aug 9, 2023
heemin32
approved these changes
Aug 9, 2023
martin-gaievski
added a commit
that referenced
this pull request
Aug 9, 2023
Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 2a9f70a)
martin-gaievski
added a commit
to martin-gaievski/neural-search
that referenced
this pull request
Aug 25, 2023
Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 2a9f70a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed typo in feature flag name for hybrid search, new name is "plugins.neural_search.hybrid_search_enabled".
Issues Resolved
#228
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.