-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Added Score Normalization and Combination feature #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Gaievski <[email protected]>
* Added Score Normalization and Combination feature Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 61e6e98)
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
backport/backport-241-to-2.x
branch
from
August 3, 2023 22:27
05c9adc
to
b41e280
Compare
Currently failing due to errors in ml-commons, they do have PR in progress to fix that opensearch-project/ml-commons#1182 |
martin-gaievski
changed the title
Backport/backport 241 to 2.x
[Backport 2.x] Added Score Normalization and Combination feature
Aug 3, 2023
martin-gaievski
force-pushed
the
backport/backport-241-to-2.x
branch
3 times, most recently
from
August 9, 2023 06:05
5a46e34
to
c1362d6
Compare
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
backport/backport-241-to-2.x
branch
from
August 9, 2023 06:20
c1362d6
to
f739f1e
Compare
Codecov Report
@@ Coverage Diff @@
## 2.x #242 +/- ##
============================================
- Coverage 89.55% 86.29% -3.27%
- Complexity 103 340 +237
============================================
Files 7 29 +22
Lines 316 992 +676
Branches 52 153 +101
============================================
+ Hits 283 856 +573
- Misses 16 70 +54
- Partials 17 66 +49
|
Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 5819df6)
Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 2a9f70a)
Closing this one as I messed up with 2.x branch in fork before this merge. Work in done under #263 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PRs related to Hybrid Search feature:
Main PR with porting from feature branch:
61e6e98 from #241
Fix feature flag apporach:
5819df6 from #246
2a9f70a from #247