-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle multi-vector in exact search scenario #1378
Handle multi-vector in exact search scenario #1378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments related to the new interface classes which we have created. I think we can do quite a lot better there. Let's see if we really need the interface and those extra functions.
src/main/java/org/opensearch/knn/index/query/FilteredKNNScorer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/index/query/FilteredFloatKNNScorer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/index/query/FilteredKNNScorer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/index/query/NestedFilteredFloatKNNScorer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/index/query/NestedFilteredFloatKNNScorer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/index/query/FilteredFloatKNNScorer.java
Outdated
Show resolved
Hide resolved
2613609
to
34a19e8
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/multi-vector #1378 +/- ##
==========================================================
+ Coverage 85.20% 85.28% +0.08%
- Complexity 1260 1276 +16
==========================================================
Files 163 167 +4
Lines 5115 5159 +44
Branches 479 482 +3
==========================================================
+ Hits 4358 4400 +42
- Misses 552 554 +2
Partials 205 205 ☔ View full report in Codecov by Sentry. |
9f82400
to
ac97dc1
Compare
src/main/java/org/opensearch/knn/index/query/filtered/KNNFloatQueryVector.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/index/query/filtered/KNNFloatQueryVector.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/index/query/filtered/NestedFilteredKNNIterator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/index/query/filtered/FilteredKNNIterator.java
Outdated
Show resolved
Hide resolved
960048a
to
87f2942
Compare
src/main/java/org/opensearch/knn/index/query/filtered/KNNFloatQueryVector.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/index/query/filtered/KNNFloatQueryVector.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/index/query/filtered/KNNFloatQueryVector.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/index/query/filtered/KNNQueryVector.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/index/query/filtered/FilteredKNNIterator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/index/query/filtered/FilteredKNNIterator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/index/query/filtered/FilteredKNNIterator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/index/query/filtered/PlainFilteredKNNIterator.java
Outdated
Show resolved
Hide resolved
87f2942
to
4b79a22
Compare
Signed-off-by: Heemin Kim <[email protected]>
4b79a22
to
56e5dc6
Compare
Build is failing due to lucene codec upgrade. |
Seeing this code is going in a feature branch, broken CI is fine. But when the whole code will be merged in main branch lets ensure that CIs are successful. |
2664a5a
into
opensearch-project:feature/multi-vector
Description
When filter query is provided using Faiss engine, knn search can be run in exact search mode instead of ANN mode based on few conditions. One of the condition is when k is larger than the size of list of filtered IDs.
This PR handles multi-vector in the exact search mode with Faiss engine.
Issues Resolved
#1065
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.