Add standalone form state for source data

[ohltyler]

Description

This PR decouples the form state for configuring source data in the "Edit source data" modal. Instead of using the global, parent form, we create a new sub-form to persist interim form state. The parent form is only updated, if a user explicitly clicks "Update", and if there are no validation errors. Following PRs will follow this same pattern for other form-based modals, including input/output transforms, and query editor modals.

Details:

• moved the modal into standalone SourceDataModal component. Here, we create a new Formik component, and persist some custom hooks etc. within it, so we can listen on changes only to the sub-form values.
• refactors state vars and state handling from SourceData -> SourceDataModal as much as possible
• add new types for the sub-form
• removes leftover legacy WorkspaceFormValues -> WorkflowFormValues for type safety

Demo video:

screen-capture.9.webm

Issues resolved

Makes progress on #446

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[ohltyler]

IT failure unrelated to this PR. After rerunning on main, it is happening there. Maybe some flaky test. Any idea @saimedhi ?

[saimedhi]

IT failure unrelated to this PR. After rerunning on main, it is happening there. Maybe some flaky test. Any idea @saimedhi ?

@ohltyler, Integ tests are passing on other PRs. I will take a look why tests are failing here.

[saimedhi]

IT failure unrelated to this PR. After rerunning on main, it is happening there. Maybe some flaky test. Any idea @saimedhi ?

@ohltyler, Integ tests are passing on other PRs. I will take a look why tests are failing here.

@ohltyler, spotted the reason for integ tests to fail. This PR needs integ test update because below is the difference when providing source data in ingest step. This PR adds update button.

Before:

Now:

[ohltyler]

@saimedhi not sure I follow. I reran on main and it is failing the same, so it's not dependent on this PR. It's only failing for the semantic search use case as well: https://github.com/opensearch-project/dashboards-flow-framework/actions/runs/11577301891/job/32286225112

[ohltyler]

@saimedhi in the meantime, can I get review of this PR? The integ test issue can be tracked separately.

[saimedhi]

@saimedhi not sure I follow. I reran on main and it is failing the same, so it's not dependent on this PR. It's only failing for the semantic search use case as well: https://github.com/opensearch-project/dashboards-flow-framework/actions/runs/11577301891/job/32286225112

• Tyler, need to change closeSourceDataButton to updateSourceDataButton in the test spec here https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/cypress/integration/plugins/dashboards-flow-framework/create_workflow_spec.js#L122

• Let me know if needed I will update.

[ohltyler]

As discussed, I will update the corresponding IT for the docs to be propagated. But, there is still the flaky issue on the same test spec that was happening in main. Let's not let either be a blocker for this PR

[ohltyler]

Button update will be fixed by opensearch-project/opensearch-dashboards-functional-test#1612

[saimedhi]

Looks good to me, tested code.

[saimedhi]

approved this PR but I am not maintainer for the Functional test repo : opensearch-project/opensearch-dashboards-functional-test#1612