Add standalone form state for query editing modal #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
This was referenced Oct 30, 2024
|
Button ID update covered in opensearch-project/opensearch-dashboards-functional-test#1612 |
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
dbwiddis
approved these changes
Oct 30, 2024
saimedhi
approved these changes
Oct 30, 2024
|
@ohltyler, Looks good to me. Thank you for updating integ tests. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit ba0dc6a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler
pushed a commit
that referenced
this pull request
Oct 30, 2024
(cherry picked from commit ba0dc6a) Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add standalone form state for query editing modal. Similar to #445, this PR nests the modal in a
Formiksub-form. Some temp vars are added to persist state. The parent form value is only updated if the user explicitly clicks "Update" and there are no validation errors.Demo video:
screen-capture.10.webm
Issues Resolved
Makes progress on #446
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.