Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][Remote Store] Permit backed futures to prevent timeouts during uploa… #13645

Merged

Conversation

vikasvb90
Copy link
Contributor

@vikasvb90 vikasvb90 commented May 13, 2024

Permit backed futures to prevent timeouts during upload bursts (#12159)

Signed-off-by: vikasvb90 [email protected]
(cherry picked from commit c328c18)

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vikasvb90
Copy link
Contributor Author

vikasvb90 commented May 13, 2024

Breaking change workflow is failing because of addition of new property lowPriorityUpload in method public void copyFrom(Directory from, String src, IOContext context, ActionListener<Void> listener, boolean lowPriorityUpload) of RemoteSegmentStoreDirectory. This class isn't used by any plugin and hence, the change doesn't really qualify as a breaking change.

Copy link
Contributor

❌ Gradle check result for 2604b90: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@vikasvb90 vikasvb90 force-pushed the backport/backport-12159-to-2.x branch from 2604b90 to 2d658c6 Compare May 14, 2024 06:25
Copy link
Contributor

❌ Gradle check result for 2d658c6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 2d658c6: SUCCESS

@gbbafna gbbafna merged commit 06945b2 into opensearch-project:2.x May 14, 2024
17 of 26 checks passed
@reta
Copy link
Collaborator

reta commented May 14, 2024

@vikasvb90 @gbbafna how come we merge pull requests with failing checks? I am revering it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants