Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Backport][Remote Store] Permit backed futures to prevent timeouts during uploa…" #13663

Merged
merged 1 commit into from
May 14, 2024
Merged

Revert "[Backport][Remote Store] Permit backed futures to prevent timeouts during uploa…" #13663

merged 1 commit into from
May 14, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented May 14, 2024

Reverts #13645

@reta reta mentioned this pull request May 14, 2024
Merged
Bukhtawar
Bukhtawar requested changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please lets take a minute to see what caused a failure. I am still checking but one the face of it looks like an issue with the workflow

@reta
Copy link
Collaborator Author

reta commented May 14, 2024 •
edited
Loading

Please lets take a minute to see what caused a failure. I am still checking but one the face of it looks like an issue with the workflow

@Bukhtawar it is failing breaking changes check, you could clearly see it: https://github.com/opensearch-project/OpenSearch/actions/runs/9074757318/job/24934080382. All other pull requests are failing because of that

@reta reta requested a review from Bukhtawar May 14, 2024 15:41
@Bukhtawar
Copy link
Collaborator

Please lets take a minute to see what caused a failure. I am still checking but one the face of it looks like an issue with the workflow

@Bukhtawar it is failing breaking changes check, you could clearly see it: https://github.com/opensearch-project/OpenSearch/actions/runs/9074757318/job/24934080382. All other pull requests are failing because of that

Thanke @reta I am not fully sure its a problem with the BWC workflow or the its a breaking change. Verifying the same

Bukhtawar
Bukhtawar approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 5aeee1c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator Author

reta commented May 14, 2024

❌ Gradle check result for 5aeee1c: FAILURE

#10006
#12197

@vikasvb90 vikasvb90 mentioned this pull request May 14, 2024
Closed
9 tasks
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 5aeee1c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dblock
Copy link
Member

dblock commented May 14, 2024

❌ Gradle check result for 5aeee1c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

org.opensearch.remotemigration.RemoteReplicaRecoveryIT.testReplicaRecovery

#13473

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 5aeee1c: SUCCESS

@dblock dblock merged commit 9de5c4f into 2.x May 14, 2024
55 of 56 checks passed
@peternied peternied deleted the revert-13645-backport/backport-12159-to-2.x branch May 14, 2024 19:56
vikasvb90 added a commit to vikasvb90/OpenSearch that referenced this pull request May 15, 2024
@vikasvb90
Reapply "[Remote Store] Permit backed futures to prevent timeouts dur…
d0f4937 
…ing uploa…" (opensearch-project#13663)

This reverts commit 9de5c4f.
vikasvb90 added a commit to vikasvb90/OpenSearch that referenced this pull request May 15, 2024
@vikasvb90
Reapply "[Remote Store] Permit backed futures to prevent timeouts dur…
2414e66 
…ing uploa…" (opensearch-project#13663)

This reverts commit 9de5c4f.

Signed-off-by: vikasvb90 <[email protected]>
dblock pushed a commit that referenced this pull request May 16, 2024
@vikasvb90
Backport 12159 to 2.x (#13681)
a95e31a 
* Reapply "[Remote Store] Permit backed futures to prevent timeouts during uploa…" (#13663)
This reverts commit 9de5c4f.

Signed-off-by: vikasvb90 <[email protected]>

* Added support of copying remote directory without specifying whether its a low priority upload

Signed-off-by: vikasvb90 <[email protected]>

---------

Signed-off-by: vikasvb90 <[email protected]>
@gbbafna gbbafna mentioned this pull request May 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owaiskazi19 owaiskazi19 owaiskazi19 approved these changes

@Bukhtawar Bukhtawar Bukhtawar approved these changes

@peternied peternied peternied approved these changes

@mch2 mch2 mch2 approved these changes

@dblock dblock dblock approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@reta @Bukhtawar @dblock @mch2 @peternied @owaiskazi19