-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate local recovery with remote store seeding during migration #12922
Integrate local recovery with remote store seeding during migration #12922
Conversation
Compatibility status:Checks if related components are compatible with change 5c328d5 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git] |
❌ Gradle check result for 59cd374: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
59cd374
to
86ed7cb
Compare
❌ Gradle check result for 86ed7cb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
...rc/internalClusterTest/java/org/opensearch/remotemigration/RemotePrimaryLocalRecoveryIT.java
Outdated
Show resolved
Hide resolved
...rc/internalClusterTest/java/org/opensearch/remotemigration/RemotePrimaryLocalRecoveryIT.java
Outdated
Show resolved
Hide resolved
86ed7cb
to
44e7217
Compare
❌ Gradle check result for 44e7217: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
f8339bc
to
0afcdd2
Compare
❌ Gradle check result for f8339bc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 0afcdd2: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12922 +/- ##
============================================
- Coverage 71.42% 71.34% -0.08%
- Complexity 59978 60653 +675
============================================
Files 4985 5044 +59
Lines 282275 285711 +3436
Branches 40946 41373 +427
============================================
+ Hits 201603 203833 +2230
- Misses 63999 65022 +1023
- Partials 16673 16856 +183 ☔ View full report in Codecov by Sentry. |
...rc/internalClusterTest/java/org/opensearch/remotemigration/RemotePrimaryLocalRecoveryIT.java
Outdated
Show resolved
Hide resolved
...rc/internalClusterTest/java/org/opensearch/remotemigration/RemotePrimaryLocalRecoveryIT.java
Show resolved
Hide resolved
...rc/internalClusterTest/java/org/opensearch/remotemigration/RemotePrimaryLocalRecoveryIT.java
Outdated
Show resolved
Hide resolved
0afcdd2
to
5c328d5
Compare
Signed-off-by: Bhumika Saini <[email protected]>
Signed-off-by: Bhumika Saini <[email protected]>
Signed-off-by: Bhumika Saini <[email protected]>
Signed-off-by: Bhumika Saini <[email protected]>
Signed-off-by: Bhumika Saini <[email protected]>
Signed-off-by: Bhumika Saini <[email protected]>
Signed-off-by: Bhumika Saini <[email protected]>
Signed-off-by: Bhumika Saini <[email protected]>
Signed-off-by: Bhumika Saini <[email protected]>
Signed-off-by: Bhumika Saini <[email protected]>
Signed-off-by: Bhumika Saini <[email protected]>
5505cfa
to
9be0001
Compare
server/src/main/java/org/opensearch/index/seqno/ReplicationTracker.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Bhumika Saini <[email protected]>
❕ Gradle check result for 9be0001: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
❕ Gradle check result for d28f6da: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12922-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a8008e2f37ec7dca061fcb7b5f84c944dd4f1108
# Push it to GitHub
git push --set-upstream origin backport/backport-12922-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…pensearch-project#12922) Signed-off-by: Bhumika Saini <[email protected]>
…12922) Signed-off-by: Bhumika Saini <[email protected]> (cherry picked from commit a8008e2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…12922) (#13428) (cherry picked from commit a8008e2) Signed-off-by: Bhumika Saini <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Integrates local recovery of shard with remote store seeding during migration of cluster to a remote backed cluster. This ensures that the data is uploaded to the remote store after performing a rolling restart as part of the docrep to remote store migration. Node restarts will also check if seeding is required and based on it will upload the data to remote.
Related Issues
#12246
#12718
Check List
Commit changes are listed out in CHANGELOG.md file (See: Changelog)(will be covered under changelog entry for the high-level feature support)Public documentation issue/PR created(not applicable)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.