Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advance(int) for numeric values in order to allow point based optimization to kick in #12089

Merged
merged 2 commits into from
Feb 1, 2024

Address code review comments

b682278
Select commit
Loading
Failed to load commit list.
Merged

Add advance(int) for numeric values in order to allow point based optimization to kick in #12089

Address code review comments
b682278
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 31, 2024 in 2s

71.38% (target 70.00%)

View this Pull Request on Codecov

71.38% (target 70.00%)

Details

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (bf5e628) 71.40% compared to head (b682278) 71.38%.
Report is 2 commits behind head on main.

Files Patch % Lines
...java/org/opensearch/index/fielddata/FieldData.java 0.00% 8 Missing ⚠️
...x/fielddata/plain/SortedNumericIndexFieldData.java 0.00% 4 Missing ⚠️
...pensearch/index/fielddata/NumericDoubleValues.java 0.00% 3 Missing ⚠️
...ain/java/org/opensearch/search/MultiValueMode.java 0.00% 2 Missing ⚠️
.../fielddata/SingletonSortedNumericDoubleValues.java 0.00% 1 Missing ⚠️
...ex/fielddata/SortableLongBitsNumericDocValues.java 0.00% 1 Missing ⚠️
...elddata/SortableLongBitsToNumericDoubleValues.java 0.00% 1 Missing ⚠️
...a/SortableLongBitsToSortedNumericDoubleValues.java 0.00% 1 Missing ⚠️
...rch/index/fielddata/SortedNumericDoubleValues.java 0.00% 1 Missing ⚠️
...x/fielddata/UnsignedLongToNumericDoubleValues.java 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #12089      +/-   ##
============================================
- Coverage     71.40%   71.38%   -0.02%     
- Complexity    59470    59512      +42     
============================================
  Files          4925     4925              
  Lines        279513   279540      +27     
  Branches      40646    40646              
============================================
- Hits         199577   199545      -32     
- Misses        63318    63392      +74     
+ Partials      16618    16603      -15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov