Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advance(int) for numeric values in order to allow point based optimization to kick in #12089

Merged
merged 2 commits into from
Feb 1, 2024

Address code review comments

b682278
Select commit
Loading
Failed to load commit list.
Merged

Add advance(int) for numeric values in order to allow point based optimization to kick in #12089

Address code review comments
b682278
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jan 31, 2024 in 0s

0.00% of diff hit (target 71.40%)

View this Pull Request on Codecov

0.00% of diff hit (target 71.40%)

Annotations

Check warning on line 82 in server/src/main/java/org/opensearch/index/fielddata/FieldData.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/FieldData.java#L82 

Added line #L82 was not covered by tests

Check warning on line 571 in server/src/main/java/org/opensearch/index/fielddata/FieldData.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/FieldData.java#L571 

Added line #L571 was not covered by tests

Check warning on line 605 in server/src/main/java/org/opensearch/index/fielddata/FieldData.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/FieldData.java#L605 

Added line #L605 was not covered by tests

Check warning on line 642 in server/src/main/java/org/opensearch/index/fielddata/FieldData.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/FieldData.java#L641-L642 

Added lines #L641 - L642 were not covered by tests

Check warning on line 708 in server/src/main/java/org/opensearch/index/fielddata/FieldData.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/FieldData.java#L708 

Added line #L708 was not covered by tests

Check warning on line 745 in server/src/main/java/org/opensearch/index/fielddata/FieldData.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/FieldData.java#L745 

Added line #L745 was not covered by tests

Check warning on line 777 in server/src/main/java/org/opensearch/index/fielddata/FieldData.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/FieldData.java#L777 

Added line #L777 was not covered by tests

Check warning on line 77 in server/src/main/java/org/opensearch/index/fielddata/NumericDoubleValues.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/NumericDoubleValues.java#L77 

Added line #L77 was not covered by tests

Check warning on line 106 in server/src/main/java/org/opensearch/index/fielddata/NumericDoubleValues.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/NumericDoubleValues.java#L106 

Added line #L106 was not covered by tests

Check warning on line 120 in server/src/main/java/org/opensearch/index/fielddata/NumericDoubleValues.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/NumericDoubleValues.java#L120 

Added line #L120 was not covered by tests

Check warning on line 74 in server/src/main/java/org/opensearch/index/fielddata/SingletonSortedNumericDoubleValues.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/SingletonSortedNumericDoubleValues.java#L74 

Added line #L74 was not covered by tests

Check warning on line 79 in server/src/main/java/org/opensearch/index/fielddata/SortableLongBitsNumericDocValues.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/SortableLongBitsNumericDocValues.java#L79 

Added line #L79 was not covered by tests

Check warning on line 72 in server/src/main/java/org/opensearch/index/fielddata/SortableLongBitsToNumericDoubleValues.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/SortableLongBitsToNumericDoubleValues.java#L72 

Added line #L72 was not covered by tests

Check warning on line 77 in server/src/main/java/org/opensearch/index/fielddata/SortableLongBitsToSortedNumericDoubleValues.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/SortableLongBitsToSortedNumericDoubleValues.java#L77 

Added line #L77 was not covered by tests

Check warning on line 82 in server/src/main/java/org/opensearch/index/fielddata/SortedNumericDoubleValues.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/SortedNumericDoubleValues.java#L82 

Added line #L82 was not covered by tests

Check warning on line 47 in server/src/main/java/org/opensearch/index/fielddata/UnsignedLongToNumericDoubleValues.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/UnsignedLongToNumericDoubleValues.java#L47 

Added line #L47 was not covered by tests

Check warning on line 52 in server/src/main/java/org/opensearch/index/fielddata/UnsignedLongToSortedNumericDoubleValues.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/UnsignedLongToSortedNumericDoubleValues.java#L52 

Added line #L52 was not covered by tests

Check warning on line 342 in server/src/main/java/org/opensearch/index/fielddata/plain/SortedNumericIndexFieldData.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/plain/SortedNumericIndexFieldData.java#L342 

Added line #L342 was not covered by tests

Check warning on line 375 in server/src/main/java/org/opensearch/index/fielddata/plain/SortedNumericIndexFieldData.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/plain/SortedNumericIndexFieldData.java#L375 

Added line #L375 was not covered by tests

Check warning on line 450 in server/src/main/java/org/opensearch/index/fielddata/plain/SortedNumericIndexFieldData.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/plain/SortedNumericIndexFieldData.java#L450 

Added line #L450 was not covered by tests

Check warning on line 483 in server/src/main/java/org/opensearch/index/fielddata/plain/SortedNumericIndexFieldData.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/fielddata/plain/SortedNumericIndexFieldData.java#L483 

Added line #L483 was not covered by tests

Check warning on line 565 in server/src/main/java/org/opensearch/index/query/functionscore/DecayFunctionBuilder.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/index/query/functionscore/DecayFunctionBuilder.java#L565 

Added line #L565 was not covered by tests

Check warning on line 691 in server/src/main/java/org/opensearch/search/MultiValueMode.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/search/MultiValueMode.java#L691 

Added line #L691 was not covered by tests

Check warning on line 756 in server/src/main/java/org/opensearch/search/MultiValueMode.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/search/MultiValueMode.java#L756 

Added line #L756 was not covered by tests

Check warning on line 232 in server/src/main/java/org/opensearch/search/aggregations/support/MissingValues.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/search/aggregations/support/MissingValues.java#L232 

Added line #L232 was not covered by tests
View more details on Codecov