Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix collection pagination hidden #959

Merged
merged 1 commit into from
Dec 24, 2024
Merged

fix collection pagination hidden #959

merged 1 commit into from
Dec 24, 2024

Conversation

adriangohjw
Copy link
Contributor

Problem

Pagination in collection are cut-off if there's too many items in the page

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible

Bug Fixes:

  • replace parent's overflow from hidden to auto

Before & After Screenshots

BEFORE:

image

AFTER:

image

@adriangohjw adriangohjw added the bug Something isn't working label Dec 23, 2024
@adriangohjw adriangohjw self-assigned this Dec 23, 2024
@adriangohjw adriangohjw requested a review from a team as a code owner December 23, 2024 15:33
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Dec 23, 2024 •
edited
Loading

Datadog Report

Branch report: fix-collection-pagination-hidden
Commit report: fa2e1cc
Test service: isomer-studio

✅ 0 Failed, 245 Passed, 36 Skipped, 47.81s Total Time
➡️ Test Sessions change in coverage: 1 no change

@adriangohjw adriangohjw merged commit 46d9781 into main Dec 24, 2024
26 checks passed
@adriangohjw adriangohjw deleted the fix-collection-pagination-hidden branch December 24, 2024 03:40
@adriangohjw adriangohjw mentioned this pull request Dec 27, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seaerchin seaerchin seaerchin approved these changes

Assignees

@adriangohjw adriangohjw

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriangohjw @seaerchin