Fix inconsistent studio dashboard layout #964
Open
+212
−228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangohjw
added
bug
Datadog ReportBranch report: ✅ 0 Failed, 245 Passed, 36 Skipped, 47.07s Total Time |
…nconsistent-studio-dashboard-layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
currently the dashboard layout for "root page", "folder" and "collection" are all incorrect, which leads to a mild inconsistencies when navigating throughtout the pages
it also means logic are duplicated and fixes have to be checked against every part
this also fixes the double scrollbar issue introduced in #959
Solution
Breaking Changes
Improvements:
DashboardcomponentBefore & After Screenshots
BEFORE:
Screen.Recording.2024-12-27.at.11.50.06.PM.mov
AFTER:
Screen.Recording.2024-12-27.at.11.51.39.PM.mov
Tests