Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tags to articles #917

Merged
merged 8 commits into from
Dec 20, 2024
Merged

feat: add tags to articles #917

merged 8 commits into from
Dec 20, 2024
+206 −43

Conversation

seaerchin
Copy link
Contributor

@seaerchin seaerchin commented Dec 5, 2024 •
edited
Loading

Problem

we need to add tags to article pages

Solution

  1. add the prop to Article - specified as props and not on schema because we don't want users to be able to add this on studio yet
  2. pass the props down to ArticlePageHeader and render it

Screenshots

image

@seaerchin seaerchin requested a review from a team as a code owner December 5, 2024 06:06
@vercel Vercel
Copy link

vercel bot commented Dec 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
isomer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 8:58am

@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Dec 5, 2024 •
edited
Loading

Datadog Report

Branch report: feat/article-page-tags
Commit report: dd69469
Test service: isomer-studio

✅ 0 Failed, 232 Passed, 36 Skipped, 38.38s Total Time
➡️ Test Sessions change in coverage: 1 no change

@seaerchin seaerchin requested review from adriangohjw and a team December 9, 2024 03:38
@seaerchin seaerchin force-pushed the feat/collection-filters branch from 1fecc16 to e971654 Compare December 17, 2024 07:34
@seaerchin seaerchin force-pushed the feat/article-page-tags branch from fb6f8c2 to bdc4feb Compare December 17, 2024 07:52
@seaerchin seaerchin force-pushed the feat/collection-filters branch from e971654 to 972af8c Compare December 17, 2024 08:01
@seaerchin seaerchin force-pushed the feat/article-page-tags branch from 00d2ce2 to e51cc4e Compare December 17, 2024 08:01
This was referenced Dec 17, 2024
Merged
Merged
@seaerchin Graphite App
Copy link
Contributor Author

seaerchin commented Dec 17, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@seaerchin seaerchin mentioned this pull request Dec 17, 2024
Merged
@seaerchin Graphite App
Copy link
Contributor Author

seaerchin commented Dec 20, 2024 •
edited
Loading

Merge activity

  • Dec 19, 10:18 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 19, 10:32 PM EST: Graphite rebased this pull request as part of a merge.
  • Dec 19, 10:39 PM EST: A user merged this pull request with Graphite.

@seaerchin seaerchin changed the base branch from feat/collection-filters to graphite-base/917 December 20, 2024 03:20
@seaerchin seaerchin changed the base branch from graphite-base/917 to main December 20, 2024 03:29
@seaerchin seaerchin force-pushed the feat/article-page-tags branch from e51cc4e to e9854f2 Compare December 20, 2024 03:31
@seaerchin seaerchin merged commit ba3520d into main Dec 20, 2024
18 of 20 checks passed
@seaerchin seaerchin deleted the feat/article-page-tags branch December 20, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harishv7 harishv7 harishv7 approved these changes

@adriangohjw adriangohjw Awaiting requested review from adriangohjw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seaerchin @harishv7 @adriangohjw