-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(collection): add blog variant for collections #924
Merged
+411
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seaerchin
changed the title
feat(collection): add blog variant for coll
feat(collection): add blog variant for collections
Dec 10, 2024
Datadog ReportBranch report: ✅ 0 Failed, 232 Passed, 36 Skipped, 38.7s Total Time 🔻 Code Coverage Decreases vs Default Branch (1)
|
seaerchin
force-pushed
the
feat/layout-cls
branch
from
December 10, 2024 11:32
55846d5
to
1cbf9de
Compare
seaerchin
force-pushed
the
feat/layout-cls
branch
from
December 10, 2024 11:40
1cbf9de
to
6bccd11
Compare
adriangohjw
had a problem deploying
to
staging
December 10, 2024 13:11 — with
GitHub Actions
Failure
adriangohjw
had a problem deploying
to
staging
December 10, 2024 13:11 — with
GitHub Actions
Failure
adriangohjw
force-pushed
the
feat/layout-cls
branch
from
December 10, 2024 13:20
605dc45
to
7d41e66
Compare
seaerchin
force-pushed
the
feat/layout-cls
branch
from
December 11, 2024 02:34
7d41e66
to
8ca7e82
Compare
seaerchin
force-pushed
the
feat/layout-cls
branch
from
December 11, 2024 02:41
8ca7e82
to
895c255
Compare
seaerchin
force-pushed
the
feat/layout-cls
branch
from
December 20, 2024 03:41
aac263e
to
b579ec4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
lg/md
and a singular column view onsm
Solution
BlogCard
component together with styling changes forCollectionResult
. theCollectionResult
displays in a grid layout with 2 cols by default and transitions into a single column layout on small screensBlogCard
, theimage
is extracted to the top together w some spacing changesBlogCard
andCollectionCard
into a single component and use thevariant
to distinguish but it seemed premature because we haven't settled on the design yet (for the blog layout), so i opted to keep it separate + flexible firstNotes
gap-3
of the containing div still applies whendisplay: none
was set on a fakediv
) - trying to figure out how to conditionally render but tw itself won't be able to do thsiVideos
Screen.Recording.2024-12-10.at.12.57.58.PM.mov
Demo
https://test-isomer-next-staging.isomer.gov.sg/cls