Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: turn on noUncheckedIndexedAccess to remove class of bugs #445

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Aug 7, 2024

TL;DR

Turn on noUncheckedIndexedAccess in component's tsconfig to prevent potential runtime errors caused by undefined index access.
Fix typecheck errors caused by the new setting.

Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
isomer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 5:08am

Copy link
Contributor Author

karrui commented Aug 7, 2024

@karrui karrui marked this pull request as ready for review August 7, 2024 04:57
@karrui karrui requested a review from a team as a code owner August 7, 2024 04:57
Copy link
Contributor Author

karrui commented Aug 7, 2024

Merge activity

  • Aug 7, 1:03 AM EDT: @karrui started a stack merge that includes this pull request via Graphite.
  • Aug 7, 1:05 AM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 7, 1:09 AM EDT: @karrui merged this pull request with Graphite.

@karrui karrui changed the base branch from 08-07-fix_unable_to_uncheck_first_filter to graphite-base/445 August 7, 2024 05:03
@karrui karrui changed the base branch from graphite-base/445 to main August 7, 2024 05:03
@karrui karrui force-pushed the 08-07-feat_turn_on_nouncheckedindexedaccess_to_remove_class_of_bugs branch from 06dce25 to 82275dd Compare August 7, 2024 05:04
@karrui karrui merged commit 6d5f173 into main Aug 7, 2024
16 checks passed
@karrui karrui deleted the 08-07-feat_turn_on_nouncheckedindexedaccess_to_remove_class_of_bugs branch August 7, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants