Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix bug where first collection filter was unable to be unchecked #444

Merged
merged 2 commits into from
Aug 7, 2024
Merged

fix: fix bug where first collection filter was unable to be unchecked #444

merged 2 commits into from
Aug 7, 2024

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Aug 7, 2024 •
edited
Loading

This PR corrects the itemIndex check in the updateAppliedFilters function within CollectionClient.

@vercel Vercel
Copy link

vercel bot commented Aug 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
isomer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 4:59am

@karrui Graphite App
Copy link
Contributor Author

karrui commented Aug 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @karrui and the rest of your teammates on Graphite Graphite

@karrui karrui mentioned this pull request Aug 7, 2024
Merged
@karrui karrui changed the title fix: use explicit undefined check instead of falsey fix: fix bug where first collection filter was unable to be unchecked Aug 7, 2024
@karrui karrui marked this pull request as ready for review August 7, 2024 04:56
@karrui karrui requested a review from a team as a code owner August 7, 2024 04:56
@karrui Graphite App
Copy link
Contributor Author

karrui commented Aug 7, 2024 •
edited
Loading

Merge activity

  • Aug 7, 1:03 AM EDT: @karrui started a stack merge that includes this pull request via Graphite.
  • Aug 7, 1:03 AM EDT: @karrui merged this pull request with Graphite.

@karrui karrui merged commit 108565d into main Aug 7, 2024
16 checks passed
@karrui karrui deleted the 08-07-fix_unable_to_uncheck_first_filter branch August 7, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcshzj dcshzj dcshzj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karrui @dcshzj