Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branding_topbar_logo #2560

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add branding_topbar_logo #2560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ Versioning](https://semver.org/spec/v2.0.0.html).

- Fix frontend translation of Enroll now for external LMS backend

### Changed

- Change `branding_topbar` to have and additonal layer in `branding_topbar_logo`

## [2.33.0] - 2024-12-02

### Added
Expand Down
5 changes: 5 additions & 0 deletions UPGRADE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,11 @@ $ make migrate
Other page levels won't be allowed to create a PageIndex extension. Commonly it would
be `0` for when your main menu list the root pages.

- After the change to the `base.html` template, you will now need to add the
`branding_topbar_logo` block to the `branding_topbar` block to have the same functionality.
If this remains the same in any site on your site factory, the `Go to homepage` link won't be
available.

## 2.31.0 to 2.33.0

- Add new `slider` plugin theme scheme:
Expand Down
6 changes: 4 additions & 2 deletions src/richie/apps/core/templates/richie/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,13 @@
<div class="topbar__container">
<header class="topbar__header">
<div class="topbar__brand">
<a href="/" title="{% trans "Go to homepage" %}" rel="home" accesskey="h">
{% block branding_topbar %}
<a href="/" title="{% trans "Go to homepage" %}" rel="home" accesskey="h">
{% block branding_topbar_logo %}
<img src="{% static "richie/images/logo.png" %}" class="topbar__logo" alt="{{ SITE.name }}">
{% endblock branding_topbar %}
{% endblock branding_topbar_logo %}
</a>
{% endblock branding_topbar %}

<button
class="topbar__hamburger"
Expand Down