Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branding_topbar_logo #2560

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sandroscosta
Copy link
Collaborator

Purpose

The current implementation of base.html template doesn't allow us to customize the link on the branding_topbar, only the logo.

Additional context

We received information form our accessibility regulation national agency that our site was not compliant. One of the things they highlighted is that the homepage h1 does not have enough context and that It would be more relevant to have it associated with the page branding (the top logo).

The suggestion is to only have a "Go back to main page" link if you're not on the main page. Also, if you're on the main page, you should see the h1 around the image.

<h1>                   
   <img src="your logo" alt="Richie">
</h1>

If you want to, you can use a different strategy:

<h1>     
   <img src="your logo" alt="Richie" aria-hidden="true">
   <span class="offscreen">Richie website</span>
</h1>

The <a> should only be present when you're not on the main page. The h1 is then replaced with a.

Proposal

Add a new block to host the site image and move the previous one to the outer block.
This will allow us to override the branding_topbar and the outer link behaviour for a11y purposes.

@sandroscosta sandroscosta force-pushed the sandroscosta/a11y/header-improvements-topbar branch from 004fcaf to 3686981 Compare December 16, 2024 14:55
@sandroscosta sandroscosta self-assigned this Dec 16, 2024
UPGRADE.md Outdated Show resolved Hide resolved
@sandroscosta sandroscosta force-pushed the sandroscosta/a11y/header-improvements-topbar branch from 3686981 to e6b3709 Compare December 17, 2024 09:17
@sandroscosta
Copy link
Collaborator Author

@jbpenrath It is giving me an error with <DashboardCreditCardsManagement> that I don't get why it is happening. Went through the file and the error and I'm not getting why it is happening. Can you provide any context? Am I missing something?

Add a new block to host the site image and move the previous
one to the outer block.
This will allow us to override the `branding_topbar` and
the outer link behaviour for a11y purposes.
This is a breaking change.
@sandroscosta sandroscosta force-pushed the sandroscosta/a11y/header-improvements-topbar branch from e6b3709 to 8e3b7b3 Compare December 18, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants