Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: osm_key duplicate column name #5960

Merged
merged 2 commits into from
Nov 29, 2024
Merged

fix: osm_key duplicate column name #5960

merged 2 commits into from
Nov 29, 2024

Conversation

M123-dev
Copy link
Member

What

Part of #5789

Actually found small typo, looks right now.
Otherwise we could use the string contains method.

@M123-dev M123-dev added the db migrations Database migrations label Nov 28, 2024
@M123-dev M123-dev changed the title Update dao_osm_location.dart osm_key duplicate column name Nov 28, 2024
@M123-dev M123-dev changed the title osm_key duplicate column name fix: osm_key duplicate column name Nov 28, 2024
monsieurtanuki
monsieurtanuki reviewed Nov 28, 2024
View reviewed changes
Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be less verbose in the expected error message and we'll be OK on different devices.

packages/smooth_app/lib/database/dao_osm_location.dart Outdated Show resolved Hide resolved
@monsieurtanuki monsieurtanuki self-requested a review November 28, 2024 18:24
monsieurtanuki
monsieurtanuki approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @M123-dev for your help!

@teolemon
Copy link
Member

Thanks @M123-dev 🙆‍♂️

@teolemon teolemon merged commit 0430192 into develop Nov 29, 2024
9 checks passed
@teolemon teolemon deleted the M123-dev-patch-1 branch November 29, 2024 11:05
@github-actions github-actions bot mentioned this pull request Nov 29, 2024
Merged
@monsieurtanuki monsieurtanuki mentioned this pull request Nov 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monsieurtanuki monsieurtanuki monsieurtanuki approved these changes

Assignees

@M123-dev M123-dev

Labels
database db migrations Database migrations Prices
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Status: 🎊 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M123-dev @teolemon @monsieurtanuki