Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 5970 - SQLITE error "typo" #5971

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

Fixes bug(s)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.53%. Comparing base (4d9c7fc) to head (1924c1d).
Report is 539 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5971      +/-   ##
==========================================
- Coverage     9.54%   6.53%   -3.02%     
==========================================
  Files          325     440     +115     
  Lines        16411   24836    +8425     
==========================================
+ Hits          1567    1623      +56     
- Misses       14844   23213    +8369     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon
Copy link
Member

The symptom is offline products not working right ?

@monsieurtanuki monsieurtanuki merged commit 43c6743 into openfoodfacts:develop Nov 30, 2024
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for your quick review!

The impact was tons of errors reported on sentry, and a method not working: "Returns the most recently locally accessed products with wrong language.", used for the language switch background task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants