Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal DB Error, duplicate column name #5789

Closed
M123-dev opened this issue Nov 5, 2024 · 9 comments · Fixed by #5799
Closed

Fatal DB Error, duplicate column name #5789

M123-dev opened this issue Nov 5, 2024 · 9 comments · Fixed by #5799

Comments

@M123-dev
Copy link
Member

M123-dev commented Nov 5, 2024

What

  • I'm on the latest internal playstore
    Screenshot_20241105_131835.jpg

Is the screen I am greeted with. Maybe I have missed some migration script but that shouldn't happen.

@monsieurtanuki
Copy link
Contributor

Duplicate with #5732.
@M123-dev Have you been playing with different versions, or just been a normal user waiting for app upgrades from Google Play?

@teolemon
Copy link
Member

teolemon commented Nov 6, 2024

@M123-dev is in internal, so prob one of the 10-20 ish people impacted by the hotfixes

@monsieurtanuki
Copy link
Contributor

@M123-dev is in internal, so prob one of the 10-20 ish people impacted by the hotfixes

Makes sense, but I prefer to double-check. We don't want this bug to happen for thousands of users, do we?

@M123-dev
Copy link
Member Author

M123-dev commented Nov 6, 2024

Duplicate with #5732. @M123-dev

Oh yes I've been looking for this one but wasn't scrolling that far


Just normal internal user. So yes I have some more versions but haven't done some manual version switching.

@monsieurtanuki
Copy link
Contributor

@M123-dev Then I guess we'd rather be careful.
I'll try to PR a fix today.

@M123-dev
Copy link
Member Author

Heyy @monsieurtanuki sorry for my admittedly very late response, am on really busy schedule rn.

My app on latest internal (seems to be from 19.11. android settings say 4.16.9) I still have the same problem.

I haven't seen someone else complain in Slack or somewhere so I guess it's a one time thing with some bad internal version mixing, maybe skipping some migrations. I'm not using the internal version that often.

Is it fine to re-install?

@monsieurtanuki
Copy link
Contributor

Hi @M123-dev! Unless there's a typo in https://github.com/openfoodfacts/smooth-app/blob/develop/packages/smooth_app/lib/database/dao_osm_location.dart#L67-L90, or for some reason the latest version of dao_osm_location.dart isn't included in the latest packaged version, you shouldn't see that error. Very strange.

Is it fine to re-install?

Normally it's fine to reinstall from scratch and it's fine to upgrade, regardless of which tango you danced with the versions.

@M123-dev
Copy link
Member Author

M123-dev commented Nov 23, 2024

@monsieurtanuki just updated again, still happening. Maybe the "Fatal Error" at the beginning 🤷, but I didn't double-check if it's coming from somewhere else in the error catching logic.

For me, it is fine to reinstall. Don't have anything important on the Play Store version, but I don't want to uninstall when this is maybe a problem others could face.
Sounds unlikely, but you are the db wizard who can tell whether it's a critical thing or just bad luck.

@monsieurtanuki
Copy link
Contributor

@M123-dev Would you please double-check the displayed error message? There may be a typo in the String I catch and check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants