fix: 5789 - catching database exceptions not supposed to happen

[monsieurtanuki]

What

• Due to approximate app versions using database version numbers back and forth, there are database incoherences in some app install.
• That PR is a fix that prevents the app from crashing at startup.

Fixes bug(s)

Fixes: #5789

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 7.07%. Comparing base (4d9c7fc) to head (aaf3a05).
Report is 427 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ages/smooth_app/lib/database/dao_osm_location.dart	0.00%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #5799      +/-   ##
==========================================
- Coverage     9.54%   7.07%   -2.48%     
==========================================
  Files          325     411      +86     
  Lines        16411   22243    +5832     
==========================================
+ Hits          1567    1574       +7     
- Misses       14844   20669    +5825     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[g123k]

Seems OK, but I wonder if we shoudn't add a reminder to remove this code in a few weeks, when new versions will be released

[monsieurtanuki]

Thank you @g123k for your review!

Seems OK, but I wonder if we shoudn't add a reminder to remove this code in a few weeks, when new versions will be released

It doesn't hurt to have ugly code now and then, especially with non ambiguous comments. And as the bug is a crash at startup and you can never be sure when a user actually updates the app, I think we should live with that stupid code forever.