-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use atlas
in make pull_translations
on palm FC-0012
#156
feat: use atlas
in make pull_translations
on palm FC-0012
#156
Conversation
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
atlas
in make pull_translations
on palmatlas
in make pull_translations
on palm FC-0012
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/palm.master #156 +/- ##
===========================================================
Coverage ? 83.01%
===========================================================
Files ? 46
Lines ? 683
Branches ? 132
===========================================================
Hits ? 567
Misses ? 116
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Makefile
Outdated
@@ -42,9 +43,24 @@ push_translations: | |||
# Pushing comments to Transifex... | |||
./node_modules/@edx/reactifex/bash_scripts/put_comments_v3.sh | |||
|
|||
ifeq ($(OPENEDX_ATLAS_PULL),) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the if
, it makes no sense here.
Changes ------- - Bump frontend-platform to bring intl-imports.js script - Move all i18n imports into `src/i18n/index.js` so intl-imports.js can override it with latest translations - Add `atlas` into `make pull_translations` when `OPENEDX_ATLAS_PULL` environment variable is set. - Fixed lint rules for [email protected] - Mock useTrackColorSchemeChoice to avoid test failures - Remove all broken and deprecated Tranisfex use - Install openedx-atlas Refs: [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) implementing Translation Infrastructure OEP-58.
f9b5f4c
to
67905f5
Compare
# Pushes translations to Transifex. You must run make extract_translations first. | ||
push_translations: | ||
# Pushing strings to Transifex... | ||
tx push -s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes no sense to keep a broken step that has no Transifex input.
@brian-smith-tcril @arbrandes would you mind merging this pull request if you think it's ready? |
@arbrandes @brian-smith-tcril should we merge this branch into Quince? At the moment it's targeting the Palm branch. |
@OmarIthawi I think it probably makes sense to keep this PR and to create a new one targeting Quince. |
@arbrandes would you mind merging this pull request if you think it's ready? |
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This is a cherry-pick of #124 into
open-release/palm.master
to fix translations for the Communications MFE and enable translations on the Tutor MFE for this app:Changes
src/i18n/index.js
so intl-imports.js can override it with latest translationsatlas
intomake pull_translations
whenOPENEDX_ATLAS_PULL
environment variable is set.TODO
tutor-mfe
pluginReference
This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.