Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use atlas in make pull_translations on palm FC-0012 #156

Merged

Conversation

OmarIthawi
Copy link
Member

@OmarIthawi OmarIthawi commented Oct 10, 2023

This is a cherry-pick of #124 into open-release/palm.master to fix translations for the Communications MFE and enable translations on the Tutor MFE for this app:

Changes

  • Bump frontend-platform to bring intl-imports.js script
  • Move all i18n imports into src/i18n/index.js so intl-imports.js can override it with latest translations
  • Add atlas into make pull_translations when OPENEDX_ATLAS_PULL environment variable is set.
  • Fixed lint rules for [email protected]
  • Mock useTrackColorSchemeChoice to avoid test failures
  • Add openedx-atlas
  • Deprecate all other Transifex broken functionality

TODO

  • Test with the tutor-mfe plugin

Reference

This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

@openedx-webhooks
Copy link

openedx-webhooks commented Oct 10, 2023

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 10, 2023
@OmarIthawi OmarIthawi changed the title feat: use atlas in make pull_translations on palm feat: use atlas in make pull_translations on palm FC-0012 Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/palm.master@ca7bc7d). Click here to learn what that means.

Additional details and impacted files
@@                     Coverage Diff                     @@
##             open-release/palm.master     #156   +/-   ##
===========================================================
  Coverage                            ?   83.01%           
===========================================================
  Files                               ?       46           
  Lines                               ?      683           
  Branches                            ?      132           
===========================================================
  Hits                                ?      567           
  Misses                              ?      116           
  Partials                            ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OmarIthawi OmarIthawi marked this pull request as draft October 12, 2023 14:55
@OmarIthawi OmarIthawi marked this pull request as ready for review October 12, 2023 14:55
@OmarIthawi OmarIthawi marked this pull request as draft October 17, 2023 14:19
Makefile Outdated
@@ -42,9 +43,24 @@ push_translations:
# Pushing comments to Transifex...
./node_modules/@edx/reactifex/bash_scripts/put_comments_v3.sh

ifeq ($(OPENEDX_ATLAS_PULL),)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the if, it makes no sense here.

Changes
-------
 - Bump frontend-platform to bring intl-imports.js script
 - Move all i18n imports into `src/i18n/index.js` so intl-imports.js can
   override it with latest translations
 - Add `atlas` into `make pull_translations` when `OPENEDX_ATLAS_PULL`
   environment variable is set.
 - Fixed lint rules for [email protected]
 - Mock useTrackColorSchemeChoice to avoid test failures
 - Remove all broken and deprecated Tranisfex use
 - Install openedx-atlas

Refs: [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) implementing Translation Infrastructure OEP-58.
# Pushes translations to Transifex. You must run make extract_translations first.
push_translations:
# Pushing strings to Transifex...
tx push -s
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes no sense to keep a broken step that has no Transifex input.

@OmarIthawi OmarIthawi marked this pull request as ready for review October 18, 2023 07:18
@OmarIthawi
Copy link
Member Author

@brian-smith-tcril @arbrandes would you mind merging this pull request if you think it's ready?

@OmarIthawi
Copy link
Member Author

@arbrandes @brian-smith-tcril should we merge this branch into Quince? At the moment it's targeting the Palm branch.

@brian-smith-tcril
Copy link
Contributor

@OmarIthawi I think it probably makes sense to keep this PR and to create a new one targeting Quince.

@OmarIthawi
Copy link
Member Author

@arbrandes would you mind merging this pull request if you think it's ready?

@brian-smith-tcril brian-smith-tcril merged commit bd85312 into openedx:open-release/palm.master Nov 3, 2023
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants