-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove broken transifex and use atlas exclusively | FC-0012 #164
Conversation
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #164 +/- ##
=======================================
Coverage 83.01% 83.01%
=======================================
Files 46 46
Lines 683 683
Branches 132 132
=======================================
Hits 567 567
Misses 116 116 ☔ View full report in Codecov by Sentry. |
@brian-smith-tcril this PR is ready for review and merge. It's a clean up PR that doesn't need to make it into Quince. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let Brian give his take before merging, but looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
ac95392
to
0b4eb58
Compare
0b4eb58
to
84e6034
Compare
I'm testing with the |
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
…penedx#164) * feat!: remove broken transifex and use atlas exclusively * feat: install openedx-atlas
…penedx#164) * feat!: remove broken transifex and use atlas exclusively * feat: install openedx-atlas
Transifex integration never worked for the communication MFE. This pull request updates the MFE to use
atlas pull
exclusively.TODO
atlas
inmake pull_translations
on palm FC-0012 #156 to be merged.master
Cherry-pick tono need to backport this clean up, because the Quince branch is ready for Tutor MFE.open-release/quince.master
References
This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.