Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove broken transifex and use atlas exclusively | FC-0012 #164

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

OmarIthawi
Copy link
Member

@OmarIthawi OmarIthawi commented Oct 18, 2023

Transifex integration never worked for the communication MFE. This pull request updates the MFE to use atlas pull exclusively.

TODO

References

This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 18, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 18, 2023

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@OmarIthawi OmarIthawi marked this pull request as draft October 18, 2023 07:27
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a299eb) 83.01% compared to head (84e6034) 83.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files          46       46           
  Lines         683      683           
  Branches      132      132           
=======================================
  Hits          567      567           
  Misses        116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brian-smith-tcril brian-smith-tcril added the blocked by other work PR cannot be finished until other work is complete label Oct 26, 2023
@OmarIthawi OmarIthawi removed the blocked by other work PR cannot be finished until other work is complete label Nov 4, 2023
@OmarIthawi OmarIthawi marked this pull request as ready for review November 4, 2023 06:30
@OmarIthawi
Copy link
Member Author

@brian-smith-tcril this PR is ready for review and merge. It's a clean up PR that doesn't need to make it into Quince.

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let Brian give his take before merging, but looks good to me!

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@OmarIthawi OmarIthawi marked this pull request as draft November 15, 2023 19:27
@OmarIthawi OmarIthawi marked this pull request as ready for review November 15, 2023 19:30
@OmarIthawi OmarIthawi marked this pull request as draft November 15, 2023 19:34
@OmarIthawi
Copy link
Member Author

I'm testing with the tutor-mfe on nightly branch.

@OmarIthawi OmarIthawi marked this pull request as ready for review November 15, 2023 20:09
@OmarIthawi
Copy link
Member Author

OmarIthawi commented Nov 15, 2023

Tested it and it worked great:

image

@brian-smith-tcril brian-smith-tcril merged commit 91402fb into openedx:master Nov 15, 2023
6 checks passed
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

arbrandes pushed a commit to arbrandes/frontend-app-communications that referenced this pull request Nov 17, 2023
…penedx#164)

* feat!: remove broken transifex and use atlas exclusively

* feat: install openedx-atlas
arbrandes pushed a commit that referenced this pull request Nov 17, 2023
)

* feat!: remove broken transifex and use atlas exclusively

* feat: install openedx-atlas
snglth pushed a commit to Abstract-Tech/community-theme-communications that referenced this pull request Jan 9, 2024
…penedx#164)

* feat!: remove broken transifex and use atlas exclusively

* feat: install openedx-atlas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants