Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce warnings in webpack prod build #2876

Merged

Conversation

christianvogt
Copy link
Contributor

https://issues.redhat.com/browse/RHOAIENG-7214
https://issues.redhat.com/browse/RHOAIENG-7213

Description

  • Fixed UseCheckboxTableBaseProps not found warning
  • Fixed browserslist warning by simply running the update command suggested
  • Could not find a solution for the Conflicting order warnings. These warnings are only valid if order of inclusion matters. Since we, and patternfly, fully quality our css rules, order should not matter. From the mini-css-extract-plugin documentation on ignoreOrder:
    • For projects where css ordering has been mitigated through consistent use of scoping or naming conventions, such as CSS Modules, the css order warnings can be disabled by setting the ignoreOrder flag to true for the plugin.

`npm run build` log output
> [email protected] build
> run-s build:prod


> [email protected] build:prod
> webpack --config ./config/webpack.prod.js


Prepping files...
  SRC DIR: /Users/cvogt/dev/odh-dashboard/frontend/src
  OUTPUT DIR: /Users/cvogt/dev/odh-dashboard/frontend/public
  PUBLIC PATH: /

Cleaning OUTPUT DIR...
  /Users/cvogt/dev/odh-dashboard/frontend/public

assets by path *.js 5.01 MiB 53 assets
assets by path images/ 488 KiB
  assets by path images/*.svg 462 KiB 48 assets
  + 2 assets
assets by path *.css 2.36 MiB
  assets by chunk 441 KiB (id hint: vendors) 10 assets
  + 14 assets
assets by path fonts/*.woff2 577 KiB
  asset fonts/fa-solid-900.woff2 77.2 KiB [emitted] [from: node_modules/@patternfly/patternfly/assets/fonts/webfonts/fa-solid-900.woff2]
  + 17 assets
assets by path *.svg 248 KiB
  asset 54f45c0fbf709bc17c51796b5a747995.svg 53 KiB [emitted]
  + 9 assets
asset index.html 450 bytes [emitted]
Entrypoint app [big] 3 MiB (7.71 MiB) = app.css 1.82 MiB app.bundle.js 1.19 MiB 2 auxiliary assets
orphan modules 19.9 MiB (javascript) 293 KiB (css/mini-extract) 102 KiB (runtime) [orphan] 11089 modules
runtime modules 10.2 KiB 14 modules
cacheable modules 11.8 MiB (javascript) 3.19 MiB (css/mini-extract)
  modules by path ./node_modules/ 8.04 MiB (javascript) 3.19 MiB (css/mini-extract)
    javascript modules 8.04 MiB 1098 modules
    css modules 3.19 MiB
      modules by path ./node_modules/@patternfly/react-styles/css/components/ 1.15 MiB 72 modules
      modules by path ./node_modules/@patternfly/react-styles/css/layouts/ 111 KiB 7 modules
      modules by path ./node_modules/@patternfly/react-topology/dist/esm/ 76.4 KiB 5 modules
      modules by path ./node_modules/@patternfly/react-styles/css/utilities/ 138 KiB 3 modules
      modules by path ./node_modules/@patternfly/patternfly/*.css 1.68 MiB 2 modules
      css ./node_modules/css-loader/dist/cjs.js!./node_modules/@patternfly/react-catalog-view-extension/dist/css/react-catalog-v...(truncated) 3.92 KiB [built] [code generated]
      css ./node_modules/css-loader/dist/cjs.js!./node_modules/@patternfly/quickstarts/dist/quickstarts.min.css 34.2 KiB [built] [code generated]
  modules by path ./src/ 3.77 MiB 373 modules

WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets: 
  app.css (1.82 MiB)
  app.bundle.js (1.19 MiB)
  5061.bundle.js (355 KiB)
  6962.bundle.js (448 KiB)
  6554.bundle.js (534 KiB)
  9036.bundle.js (617 KiB)

WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
Entrypoints:
  app (3 MiB)
      app.css
      app.bundle.js


webpack 5.88.2 compiled with 2 warnings in 59775 ms

How Has This Been Tested?

npm run build

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from DaoDaoNoCode and dpanshug June 4, 2024 14:35
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.74%. Comparing base (ac0fc61) to head (7a5e952).
Report is 20 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2876      +/-   ##
==========================================
- Coverage   78.75%   78.74%   -0.01%     
==========================================
  Files        1101     1101              
  Lines       23440    23440              
  Branches     5907     5907              
==========================================
- Hits        18459    18457       -2     
- Misses       4981     4983       +2     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac0fc61...7a5e952. Read the comment docs.

@christianvogt christianvogt force-pushed the webpack-warnings branch 2 times, most recently from 7d77cc3 to 7a5e952 Compare June 5, 2024 20:21
@pnaik1
Copy link
Contributor

pnaik1 commented Jun 7, 2024

the warning is reduced
/lgtm
Screenshot from 2024-06-07 23-59-45

Copy link
Contributor

openshift-ci bot commented Jun 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b4db549 into opendatahub-io:main Jun 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants