reduce bundle size related to lodash

opendatahub-io · Jun 5, 2024 · 7d77cc3 · 7d77cc3
1 parent 7a5e952
commit 7d77cc3
Show file tree

Hide file tree

Showing 9 changed files with 14 additions and 13 deletions.
diff --git a/frontend/config/webpack.common.js b/frontend/config/webpack.common.js
@@ -232,6 +232,7 @@ module.exports = (env) => {
       extensions: ['.js', '.ts', '.tsx', '.jsx'],
       alias: {
         '~': path.resolve(SRC_DIR),
+        lodash: 'lodash-es',
       },
       symlinks: false,
       cacheWithContext: false,

diff --git a/frontend/src/__mocks__/mockByon.ts b/frontend/src/__mocks__/mockByon.ts
@@ -1,5 +1,5 @@
 /* eslint-disable camelcase */
-import _ from 'lodash-es';
+import * as _ from 'lodash-es';
 
 import { RecursivePartial } from '~/typeHelpers';
 import { BYONImage } from '~/types';

diff --git a/frontend/src/__mocks__/mockImageStreamK8sResource.ts b/frontend/src/__mocks__/mockImageStreamK8sResource.ts
@@ -1,4 +1,4 @@
-import _ from 'lodash-es';
+import * as _ from 'lodash-es';
 import { ImageStreamKind } from '~/k8sTypes';
 import { RecursivePartial } from '~/typeHelpers';
 

diff --git a/frontend/src/__mocks__/mockNotebookK8sResource.ts b/frontend/src/__mocks__/mockNotebookK8sResource.ts
@@ -1,4 +1,4 @@
-import _ from 'lodash-es';
+import * as _ from 'lodash-es';
 import { KnownLabels, NotebookKind } from '~/k8sTypes';
 import { DEFAULT_NOTEBOOK_SIZES } from '~/pages/projects/screens/spawner/const';
 import { ContainerResources, TolerationEffect, TolerationOperator } from '~/types';

diff --git a/frontend/src/__tests__/cypress/cypress/utils/k8s.ts b/frontend/src/__tests__/cypress/cypress/utils/k8s.ts
@@ -3,7 +3,7 @@ import {
   type K8sResourceCommon,
   type QueryParams,
 } from '@openshift/dynamic-plugin-sdk-utils';
-import { isEmpty } from 'lodash-es';
+import * as _ from 'lodash-es';
 
 export type QueryOptions = {
   ns?: string;
@@ -85,7 +85,7 @@ const getK8sResourceURL = (
 
   const filteredQueryParams = queryParams;
 
-  if (filteredQueryParams && !isEmpty(filteredQueryParams)) {
+  if (filteredQueryParams && !_.isEmpty(filteredQueryParams)) {
     resourcePath += `?${getQueryString(filteredQueryParams)}`;
   }
 

diff --git a/frontend/src/components/table/useCheckboxTableBase.ts b/frontend/src/components/table/useCheckboxTableBase.ts
@@ -1,5 +1,5 @@
 import * as React from 'react';
-import { intersection, xor } from 'lodash-es';
+import * as _ from 'lodash-es';
 import type Table from './Table';
 
 export type UseCheckboxTableBaseProps<DataType> = {
@@ -33,7 +33,7 @@ const useCheckboxTableBase = <T>(
       return;
     }
 
-    const newSelectedIds = intersection(selectedDataIds, dataIds);
+    const newSelectedIds = _.intersection(selectedDataIds, dataIds);
     const newSelectedData = newSelectedIds
       .map((id) => data.find((d) => dataMappingHelper(d) === id))
       .filter((v): v is T => !!v);
@@ -71,7 +71,7 @@ const useCheckboxTableBase = <T>(
 
     const headerSelected =
       selectedDataIds.length > 0 &&
-      xor(selectedDataIds, checkable.map(dataMappingHelper)).length === 0;
+      _.xor(selectedDataIds, checkable.map(dataMappingHelper)).length === 0;
 
     const allDisabled = selectedData.length === 0 && disabledData.length === data.length;
 

diff --git a/frontend/src/redux/selectors/utils.ts b/frontend/src/redux/selectors/utils.ts
@@ -1,4 +1,4 @@
-import { isEqual } from 'lodash-es';
+import * as _ from 'lodash-es';
 
 export const isStateEqual = <T>(stateBefore: T, stateAfter: T): boolean =>
-  isEqual(stateBefore, stateAfter);
+  _.isEqual(stateBefore, stateAfter);
diff --git a/frontend/src/utilities/tolerations.ts b/frontend/src/utilities/tolerations.ts
@@ -1,5 +1,5 @@
 import { Patch } from '@openshift/dynamic-plugin-sdk-utils';
-import _ from 'lodash-es';
+import * as _ from 'lodash-es';
 import { Toleration, TolerationEffect, TolerationOperator, TolerationSettings } from '~/types';
 import { DashboardConfigKind, NotebookKind } from '~/k8sTypes';
 import { AcceleratorProfileState } from './useAcceleratorProfileState';

diff --git a/frontend/tsconfig.json b/frontend/tsconfig.json
@@ -3,8 +3,8 @@
     "rootDir": ".",
     "outDir": "public",
     "module": "esnext",
-    "target": "es5",
-    "lib": ["es6", "dom", "ES2023.Array"],
+    "target": "es2016",
+    "lib": ["dom", "ES2023.Array"],
     "sourceMap": true,
     "jsx": "react",
     "moduleResolution": "node",