Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-4385] DSPA - Add back the Folder Info #2843

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented May 22, 2024

Closes: RHOAIENG-4385

Description

Added info alert with popover for Bucket field in the Configure Pipeline modal

image (cc @yannnz)

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from dpanshug and manaswinidas May 22, 2024 23:35
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.47%. Comparing base (7d5b99f) to head (7c313f8).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2843   +/-   ##
=======================================
  Coverage   78.47%   78.47%           
=======================================
  Files        1127     1127           
  Lines       23955    23958    +3     
  Branches     6042     6044    +2     
=======================================
+ Hits        18798    18802    +4     
+ Misses       5157     5156    -1     
Files Coverage Δ
.../configurePipelinesServer/ObjectStorageSection.tsx 100.00% <100.00%> (ø)
...ipelines/content/configurePipelinesServer/const.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d5b99f...7c313f8. Read the comment docs.

@DaoDaoNoCode
Copy link
Member

Hi @jpuzz0, is there a mockup that I can refer to?

@jpuzz0
Copy link
Contributor Author

jpuzz0 commented May 23, 2024

Hi @jpuzz0, is there a mockup that I can refer to?

Hey @DaoDaoNoCode, yes, this is the design, but it has changed a few times over the past couple days. Today some of the bold text has been updated, so I will address that, and there is still an outstanding question about the "Elyra" bit at the end. I would consider just the means in which the popover, general presentation, etc to be reviewable right now, but the content text itself is still up in the air slightly.

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
This could be merged after the text is decided.

@openshift-ci openshift-ci bot added the lgtm label May 23, 2024
@jpuzz0 jpuzz0 added the do-not-merge/hold This PR is hold for some reason label May 23, 2024
@openshift-ci openshift-ci bot removed the lgtm label Jun 10, 2024
@jpuzz0 jpuzz0 requested a review from yannnz June 10, 2024 16:23
@jpuzz0 jpuzz0 removed the do-not-merge/hold This PR is hold for some reason label Jun 11, 2024
@jpuzz0
Copy link
Contributor Author

jpuzz0 commented Jun 11, 2024

This is good to re-review @DaoDaoNoCode

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 11, 2024
@jpuzz0
Copy link
Contributor Author

jpuzz0 commented Jun 12, 2024

FYI, I spoke with @jgarciao today and he confirmed the usage of the cloud service link for "Learn more".

@openshift-ci openshift-ci bot removed the lgtm label Jun 13, 2024
@Gkrumbach07
Copy link
Member

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9484646 into opendatahub-io:main Jun 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants