Skip to content

Commit

Permalink
Merge pull request #2843 from jpuzz0/RHOAIENG-4385
Browse files Browse the repository at this point in the history
[RHOAIENG-4385] DSPA - Add back the Folder Info
  • Loading branch information
openshift-merge-bot[bot] authored Jun 13, 2024
2 parents 354693d + 7c313f8 commit 9484646
Show file tree
Hide file tree
Showing 2 changed files with 46 additions and 11 deletions.
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import React from 'react';
import {
FormSection,
Title,
Expand All @@ -7,14 +8,17 @@ import {
InputGroup,
Tooltip,
InputGroupItem,
Alert,
Popover,
} from '@patternfly/react-core';
import React from 'react';
import { DataConnection } from '~/pages/projects/types';
import { PIPELINE_AWS_FIELDS } from '~/pages/projects/dataConnections/const';
import { AwsKeys, PIPELINE_AWS_FIELDS } from '~/pages/projects/dataConnections/const';
import { FieldListField } from '~/components/FieldList';
import ExternalLink from '~/components/ExternalLink';
import { PipelineDropdown } from './PipelineDropdown';
import { PipelineServerConfigType } from './types';
import './ConfigurePipelinesServerModal.scss';
import { PipelineDropdown } from './PipelineDropdown';
import { storingDataHelpLink } from './const';

export type FieldOptions = {
key: string;
Expand Down Expand Up @@ -85,14 +89,42 @@ export const ObjectStorageSection = ({
</InputGroup>
</FormGroup>
) : (
<FieldListField
key={field.key}
value={
config.objectStorage.newValue.find((data) => data.key === field.key)?.value || ''
}
options={field}
onChange={onChange}
/>
<>
<FieldListField
key={field.key}
value={
config.objectStorage.newValue.find((data) => data.key === field.key)?.value || ''
}
options={field}
onChange={onChange}
/>

{field.key === AwsKeys.AWS_S3_BUCKET && (
<Popover
aria-label="bucket tooltip"
headerContent="Where is my data stored within the bucket?"
position="right"
hasAutoWidth
bodyContent={
<div className="pf-v5-u-mt-md">
Uploaded pipelines will be stored in the <b>/pipelines</b> directory.
<br />
When running a pipeline, artifacts will be stored in dedicated folders at the{' '}
<b>/root</b> directory.
</div>
}
footerContent={<ExternalLink text="Learn more" to={storingDataHelpLink} />}
>
<Alert
variant="info"
isInline
isPlain
title="Where is my data stored within the bucket?"
style={{ width: 'fit-content' }}
/>
</Popover>
)}
</>
),
)}
</FormSection>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,6 @@ export const EMPTY_DATABASE_CONNECTION: EnvVariableDataEntry[] = [
value: '',
},
];

export const storingDataHelpLink =
'https://access.redhat.com/documentation/en-us/red_hat_openshift_ai_cloud_service/1/html/working_on_data_science_projects/working-with-data-science-pipelines_ds-pipelines#storing-data-with-data-science-pipelines_ds-pipelines';

0 comments on commit 9484646

Please sign in to comment.