Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistency in authentication #2824

Merged
merged 1 commit into from
Jun 14, 2024

Fix inconsistency in token section for model serving

5e1b3d8
Select commit
Loading
Failed to load commit list.
Merged

Fix inconsistency in authentication #2824

Fix inconsistency in token section for model serving
5e1b3d8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 14, 2024 in 0s

78.78% (+1.31%) compared to a7032c6

View this Pull Request on Codecov

78.78% (+1.31%) compared to a7032c6

Details

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.78%. Comparing base (a7032c6) to head (5e1b3d8).
Report is 82 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2824      +/-   ##
==========================================
+ Coverage   77.46%   78.78%   +1.31%     
==========================================
  Files        1110     1105       -5     
  Lines       23521    23493      -28     
  Branches     5937     5925      -12     
==========================================
+ Hits        18220    18508     +288     
+ Misses       5301     4985     -316     
Files Coverage Δ
...src/pages/home/aiFlows/DeployAndMonitorGallery.tsx 100.00% <ø> (ø)
...s/KServeSection/KServeInferenceServiceTableRow.tsx 88.46% <ø> (ø)
...lServing/screens/projects/ModelServingPlatform.tsx 96.38% <100.00%> (ø)
...screens/projects/kServeModal/ManageKServeModal.tsx 92.23% <ø> (ø)
...ServingRuntimeModal/ServingRuntimeTokenSection.tsx 78.94% <0.00%> (ø)
.../ServingRuntimeModal/AuthServingRuntimeSection.tsx 82.75% <0.00%> (ø)

... and 104 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7032c6...5e1b3d8. Read the comment docs.