Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistency in authentication #2824

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

lucferbux
Copy link
Contributor

@lucferbux lucferbux commented May 20, 2024

Closes https://issues.redhat.com/browse/RHOAIENG-382

Description

Fix inconsistency in authentication working for model serving.

Screenshot 2024-05-23 at 02 38 16

How Has This Been Tested?

  1. Deploy a model through KServe
  2. Select external route
  3. Text should match "Token authentication"

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@lucferbux
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot requested review from dpanshug and Gkrumbach07 May 20, 2024 16:25
@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label May 20, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.78%. Comparing base (a7032c6) to head (5e1b3d8).
Report is 82 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2824      +/-   ##
==========================================
+ Coverage   77.46%   78.78%   +1.31%     
==========================================
  Files        1110     1105       -5     
  Lines       23521    23493      -28     
  Branches     5937     5925      -12     
==========================================
+ Hits        18220    18508     +288     
+ Misses       5301     4985     -316     
Files Coverage Δ
...src/pages/home/aiFlows/DeployAndMonitorGallery.tsx 100.00% <ø> (ø)
...s/KServeSection/KServeInferenceServiceTableRow.tsx 88.46% <ø> (ø)
...lServing/screens/projects/ModelServingPlatform.tsx 96.38% <100.00%> (ø)
...screens/projects/kServeModal/ManageKServeModal.tsx 92.23% <ø> (ø)
...ServingRuntimeModal/ServingRuntimeTokenSection.tsx 78.94% <0.00%> (ø)
.../ServingRuntimeModal/AuthServingRuntimeSection.tsx 82.75% <0.00%> (ø)

... and 104 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7032c6...5e1b3d8. Read the comment docs.

@lucferbux lucferbux force-pushed the rhoaieng-6651 branch 2 times, most recently from 36b009c to e248dfb Compare May 23, 2024 00:37
@lucferbux
Copy link
Contributor Author

@kaedward @vconzola can you guys take a look at this?

@lucferbux lucferbux closed this May 23, 2024
@lucferbux lucferbux changed the title Add external route option for kserve Fix inconsistenci in authentication May 23, 2024
@lucferbux lucferbux reopened this May 23, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label May 31, 2024
@vconzola
Copy link

@lucferbux I'm not sure what we're supposed to be looking at. The change was just to replace "authorization" with "authentication" throughout, correct? It looks like your PR does that. Is there anything else we need to review? cc: @kaedward

@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Jun 3, 2024
@lucferbux lucferbux changed the title Fix inconsistenci in authentication Fix inconsistency in authentication Jun 3, 2024
@lucferbux lucferbux force-pushed the rhoaieng-6651 branch 2 times, most recently from 4b0f487 to 7451643 Compare June 3, 2024 15:10
@lucferbux
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold This PR is hold for some reason label Jun 6, 2024
@lucferbux
Copy link
Contributor Author

@lucferbux I'm not sure what we're supposed to be looking at. The change was just to replace "authorization" with "authentication" throughout, correct? It looks like your PR does that. Is there anything else we need to review? cc: @kaedward

Oh yes, that was it, just to confirm those were the changes

@lucferbux lucferbux requested a review from mturley June 6, 2024 09:37
@lucferbux
Copy link
Contributor Author

/approve

Copy link
Contributor

openshift-ci bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gitdallas, lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lucferbux
Copy link
Contributor Author

/retest

@lucferbux
Copy link
Contributor Author

/test odh-dashboard-pr-image-mirror

@openshift-merge-bot openshift-merge-bot bot merged commit fb15db0 into opendatahub-io:main Jun 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants