-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistency in authentication #2824
Fix inconsistency in authentication #2824
Conversation
/hold |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2824 +/- ##
==========================================
+ Coverage 77.46% 78.78% +1.31%
==========================================
Files 1110 1105 -5
Lines 23521 23493 -28
Branches 5937 5925 -12
==========================================
+ Hits 18220 18508 +288
+ Misses 5301 4985 -316
... and 104 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
36b009c
to
e248dfb
Compare
@lucferbux I'm not sure what we're supposed to be looking at. The change was just to replace "authorization" with "authentication" throughout, correct? It looks like your PR does that. Is there anything else we need to review? cc: @kaedward |
4b0f487
to
7451643
Compare
/unhold |
Oh yes, that was it, just to confirm those were the changes |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gitdallas, lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test odh-dashboard-pr-image-mirror |
Closes https://issues.redhat.com/browse/RHOAIENG-382
Description
Fix inconsistency in authentication working for model serving.
How Has This Been Tested?
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main