Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sync preferred project when switching to global model serving page #2154

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Nov 15, 2023

Closes #2137

Description

  1. When you switch between the navs (projects, pipelines, model serving), the preferred project is always remembered and synced up
  2. When you choose All projects on the global model serving page, the preferred project is set to null (We don't have that dropdown selection on the pipelines page)
  3. Remove the filter label so you could select all the available projects on the global model serving page, but not only the dashboard projects
  4. Fix some nits from Merge f/model-serving to main #2123

How Has This Been Tested?

  1. Go to the projects page
  2. Get into any project
  3. Click on the model serving on the side nav
  4. You should be able to land on the page with the same selection as the project you just entered
  5. Go to the pipelines page, you can see the selection is kept
  6. Select All projects on the global model serving page
  7. Make sure everything works

Test Impact

N/A, this needs e2e test setup IMO.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@DaoDaoNoCode
Copy link
Member Author

/hold
Do not merge until #2135 is fixed because this change will make the performance issue worse.

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Nov 15, 2023
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually this is fine by me...

There is a performance issue that will prevent me from approving here. It is a separate issue, but this will expose it more.

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach is better, I'm gonna test it later with my fix to see if helps

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lucferbux
Copy link
Contributor

/lgtm

@lucferbux
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Nov 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a1b90b5 into opendatahub-io:main Nov 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Improve global model serving project selection
3 participants