Merge f/model-serving to main
#2123
Conversation
Revamp add server button and add tooltip
Show alert when external route is set while token is not set for model server
Improvements to edit model server modal
Make data connection bucket field mandatory
Check serving runtime kind at creation time
Update ovms and add Caikit Custom Serving Runtime
Create dashboard configuration to control kserve and modelmesh
Adapt custom serving runtimes to KServe
Update ovms with gpu support and remove the other template
Add check for dsc status and utility types to check serving platform availablity
Add model serving platform settings
handle kserve in global model serving page
Refactor model serving section on the project details page
Add empty state when no serving platform is enabled
Fix merging issues
Improve route handling
Support Caikit Serving Runtime with REST
Add deployment to global view and fix status
There was a problem hiding this comment.
Questions I would like answered asap:
- Merge
f/model-servingtomain#2123 (comment) - Merge
f/model-servingtomain#2123 (comment) - Merge
f/model-servingtomain#2123 (comment)
The rest is followup / cleanup. Log tickets as needed to work through things.
frontend/src/__tests__/integration/pages/modelServing/ModelServingGlobal.stories.tsx
Show resolved
Hide resolved
| export const addSupportModelMeshProject = (name: string): Promise<string> => | ||
| axios(`/api/namespaces/${name}/1`).then((response) => { | ||
| export const addSupportServingPlatformProject = ( | ||
| name: string, | ||
| servingPlatform: NamespaceApplicationCase, | ||
| ): Promise<string> => | ||
| axios(`/api/namespaces/${name}/${servingPlatform}`).then((response) => { |
There was a problem hiding this comment.
We probably should have improved this not to use /1 if we were just going to place the constant values in the frontend code. We could have gone with a more reasonable endpoint name.
@lucferbux please log a tech debt for us to look into this.
There was a problem hiding this comment.
@christianvogt would this not better serve to be part of the table folder of items? Do we expect this to not be table related? "Resource Actions" technically doesn't need to be, but I imagine this is the only use-case we know today for "marked for delete"
There was a problem hiding this comment.
Yes it's table specific and probably should be put into the table dir.
frontend/src/pages/modelServing/screens/global/InferenceServiceListView.tsx
Show resolved
Hide resolved
frontend/src/pages/modelServing/screens/global/ModelServingProjectSelection.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Dead code, please remove.
| existingTemplate.metadata.annotations | ||
| ? { | ||
| op: 'replace', | ||
| path: '/metadata/annotations/opendatahub.io~1modelServingSupport', | ||
| value: JSON.stringify(platforms), | ||
| } | ||
| : { | ||
| op: 'add', | ||
| path: '/metadata/annotations', | ||
| value: { | ||
| 'opendatahub.io/modelServingSupport': JSON.stringify(platforms), | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Dupe code. frontend/src/api/k8s/templates.ts -- we should resolve this... it'll be a maintenance annoyance.
Change empty global model mesh serving link text to project display name
Change base image of text generation inference container
Show error state on global serving page when the platform in not installed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Closes #1810