-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle kserve in global model serving page #2001
handle kserve in global model serving page #2001
Conversation
7343fa2
to
ce8c1ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so far the changes look good, we need to review the logic to delete the ServingRuntime
as we'll need to delete other resources too and there's a new version of the mockups, if you can take a look would be awesome!
inferenceService.metadata.namespace, | ||
), | ||
servingRuntime | ||
? deleteServingRuntime( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be aware that there are several resources to delete with the serving runtime too, such as the rolebinding, secrets and more, I think we could cover this in #1998 but this logic should be similar to https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/src/pages/modelServing/screens/projects/DeleteServingRuntimeModal.tsx#L50
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The complex deletion of the ServingRuntime should be handled in #1998.
That being said, I am deleting two related resources here and I wonder if we should rely on creating an ownerReference between InferenceService and ServingRuntime for kserve. If so then I don't need to delete both resources here.
ce8c1ed
to
f667bb8
Compare
f667bb8
to
5b9e0e8
Compare
@lucferbux I update the PR to include the latest UX change for the project label. I've also removed the deletion change I initially made in lieu of #1998. As per our slack conversation, we will utilize |
<> | ||
{project ? ( | ||
<> | ||
{getProjectDisplayName(project)}{' '} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could give a little bit of padding, but that can be a follow up enhancement and we can discuss it later with UX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I've left a little nit that we can change later on, but we can unblock this
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7ec208c
into
opendatahub-io:f/model-serving
LGTM |
Addresses most of #1948 but not everything since the edit modal for kserve isn't yet available. For now the edit action for a kserve inference service is disabled.
Also does not expose GRPC url in table (out of scope).
Does not address deletion of
ServingRuntime
as this will be addressed byownerReferences
when we create the kserveServingRuntime
andInferenceService
- related to #1998Description
Updates the model serving table to display column for
Serving runtime
and removes theModel server
column.Changed title of the global model serving page to
Deployed models
fyi @vconzola
How Has This Been Tested?
ServingRuntime
InferenceService
InferenceService
and change annotationserving.kserve.io/deploymentMode
to a value other thanModelMesh
Model Serving
page using the left navigationInferenceService
and observe thatEdit
is disabledDelete
actionInferenceService
is deleted (Note that until the kserve creation flows are complete, theServingRuntime
will not be deleted as we will rely onownerReferences
)Test Impact
Added some unit tests.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main