Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story]: Adapt Global View Table to Kserve #1948

Closed
lucferbux opened this issue Oct 10, 2023 · 6 comments · Fixed by #2001
Closed

[Story]: Adapt Global View Table to Kserve #1948

lucferbux opened this issue Oct 10, 2023 · 6 comments · Fixed by #2001
Assignees
Labels
feature/model-serving Model Serving Feature kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.

Comments

@lucferbux
Copy link
Contributor

lucferbux commented Oct 10, 2023

Goal

Adapt global view to support kserve deployed models

Dependency issue

No dependencies

Itemized goals

  • Add a new column in the Global View Table to display the Serving Runtime platform
  • The way to detect that is by some annotations in the InferenceService serving.kserve.io/deploymentMode: ModelMesh
  • Add logic to display the proper modal when editing a new model (Kserve/modelmesh)

Aspects continued elsewhere

No response

Mocks

@lucferbux lucferbux added priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. labels Oct 10, 2023
@lucferbux lucferbux added the feature/model-serving Model Serving Feature label Oct 10, 2023
@lucferbux
Copy link
Contributor Author

We need to review this, and we might slip this view or either deprioritize or add a workaround, I'm not sure if we can get this for this sprint given the early stages.

cc @vconzola @andrewballantyne

@andrewballantyne
Copy link
Member

This is a two step process imo... not sure if we want both in the same ticket, but here are my thoughts.

  1. Adapting the table to support both types should be fairly straight forward
    • Edit on each row shouldn't be a problem either, as it's an if/else sorta situation
    • Showing a label or column should be fairly easy given knowledge of the project it comes from
    • Delete will need to adapt, worse case scenario two flows
  2. Deploy is a little weird from this page as project selection will change the rest of the modal... but I imagine that's not too crazy either
    • We need to support Model Mesh server deploys... perhaps this is the biggest annoyance of them all as we never got to it from the other issue
    • We shouldn't have a problem deploying a model from KServe or Model Mesh as we just expand the modal on project selection

We can work through the nit and grit @lucferbux

@lucferbux
Copy link
Contributor Author

Yes, I should have mentioned that this is just a placeholder, I was thinking about splitting the different goals once we are sure what we want for this screen. n1 is quite clear, I envisioned something similar, and we can work through n2 to get the requirements.

@lucferbux lucferbux changed the title [Story]: Adapt Global View to kserve [Story]: Adapt Global View Table to Kserve Oct 11, 2023
@lucferbux lucferbux moved this from Untriaged to Dev To do in ODH Dashboard Planning Oct 16, 2023
@christianvogt christianvogt self-assigned this Oct 19, 2023
@christianvogt christianvogt moved this from Dev To do to Dev In progress in ODH Dashboard Planning Oct 19, 2023
@lucferbux
Copy link
Contributor Author

@christianvogt since you got this, the only blocker here is that when editing, we are blocked by #1943, you can just add the logic there and we can later add it when working on 1943.

@christianvogt
Copy link
Contributor

Yes @lucferbux. My plan was to stub out the condition and mark as TODO.

@lucferbux lucferbux linked a pull request Oct 25, 2023 that will close this issue
7 tasks
@lucferbux
Copy link
Contributor Author

@christianvogt I'm sorry, @vconzola has updated the mocks with the inclusion of the label Multi-model serving enabled and Single-model serving enabled could you add that too please?

@lucferbux lucferbux moved this from Dev In progress to Done in ODH Dashboard Planning Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/model-serving Model Serving Feature kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
Status: Done
Status: No status
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants