Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ovms with gpu support and remove the other template #1999

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

lucferbux
Copy link
Contributor

@lucferbux lucferbux commented Oct 20, 2023

Description

Closes #1989

How Has This Been Tested?

  1. Delete the old templates
  2. Deploy the new templates
  3. Create a new ovms model with the new Custom Serving Runtime
  4. NOT TESTED IN A GPU CLUSTER, WE SHOULD DO THAT AT ONE POINT BEFORE THE RELEASE

Test Impact

Not needed, manifest files, we'll might include something for e2e testing in the future.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from alexcreasy and dpanshug October 20, 2023 15:42
@lucferbux lucferbux linked an issue Oct 20, 2023 that may be closed by this pull request
@lucferbux
Copy link
Contributor Author

@Xaenalt can you take a look the spec is correct please?

manifests/modelserving/ovms-ootb.yaml Outdated Show resolved Hide resolved
manifests/modelserving/kustomization.yaml Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm label Oct 22, 2023
@Xaenalt
Copy link
Member

Xaenalt commented Oct 22, 2023

A note we may need to bump the image version again later for that CVE that's been going around

@lucferbux
Copy link
Contributor Author

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux, Xaenalt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 3178441 into opendatahub-io:f/model-serving Oct 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Story]: Add new OVMS OOTB template
2 participants