Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story]: Add new OVMS OOTB template #1989

Closed
lucferbux opened this issue Oct 19, 2023 · 2 comments · Fixed by #1999
Closed

[Story]: Add new OVMS OOTB template #1989

lucferbux opened this issue Oct 19, 2023 · 2 comments · Fixed by #1999
Assignees
Labels
feature/model-serving Model Serving Feature kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.

Comments

@lucferbux
Copy link
Contributor

lucferbux commented Oct 19, 2023

Goal

Implement new ovms image and deprecate the GPU one

Dependency issue

No dependencies

Itemized goals

  • Figure out how to remove the gpu OOTB for already deployed servers (it appears it should be done by the operator automatically)
  • Change the image from the OVMS template based on the latest template
  • Remove the gpu limitation from the OVMS template

Aspects continued elsewhere

No response

Mocks

No mocks

@lucferbux lucferbux added priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. labels Oct 19, 2023
@lucferbux lucferbux moved this from Untriaged to Dev To do in ODH Dashboard Planning Oct 19, 2023
@lucferbux lucferbux added the feature/model-serving Model Serving Feature label Oct 19, 2023
@lucferbux
Copy link
Contributor Author

cc @zdtsw @VaishnaviHire based on conversations, it seems that ovms-gpu-ootb.yaml will be removed in already deployed installations on an upgrade path, is that right? If so we can get this and then check the upgrade path if it's working

@zdtsw
Copy link
Member

zdtsw commented Oct 20, 2023

cc @zdtsw @VaishnaviHire based on conversations, it seems that ovms-gpu-ootb.yaml will be removed in already deployed installations on an upgrade path, is that right? If so we can get this and then check the upgrade path if it's working

i think the easy way is to build a new local image, use a base catalog which still has the ovms-gpu-ootb.yaml included. and test the upgrade if the old instance gets cleaned up after upgrade.
in theory, i see this as a general case: when an old resource is removed from manifests, it should be auto removed after operator reconcile.

but i am not sure, how it will be if it's from v1 to v2(as if someone created ovms-gpu-ootb by operator v1 then upgrade to operator v2, will that be cleaned up or hanging in the cluster)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/model-serving Model Serving Feature kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
Status: Done
Status: No status
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants